Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add pause/resume commands for Update Channels #2614

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

FiberJW
Copy link
Contributor

@FiberJW FiberJW commented Oct 10, 2024

Why

We want to allow developers to prevent updates from being served to certain builds by "pausing" update channels.

How

  • I added two new CLI commands to toggle the channel pausing state
  • I added the pause status to the channel details output in the view and list commands

Test Plan

Build the CLI locally under the neas alias, and run neas channel:pause development && neas channel:view development && neas channel:resume development && neas channel:view development:

Screenshot 2024-10-17 at 05 33 36

@FiberJW FiberJW changed the title [eas-cli] add channel pause/resume commands for Update Channels [eas-cli] add pause/resume commands for Update Channels Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 53.12500% with 45 lines in your changes missing coverage. Please review.

Project coverage is 53.12%. Comparing base (20b76f7) to head (b77b178).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/channel/pause.ts 46.16% 21 Missing ⚠️
packages/eas-cli/src/commands/channel/resume.ts 46.16% 21 Missing ⚠️
packages/eas-cli/src/channel/queries.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
+ Coverage   53.12%   53.12%   +0.01%     
==========================================
  Files         564      566       +2     
  Lines       21474    21566      +92     
  Branches     4198     4211      +13     
==========================================
+ Hits        11405    11454      +49     
- Misses      10039    10082      +43     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 10, 2024

Size Change: +1.74 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +1.74 kB (0%)

compressed-size-action

@FiberJW FiberJW force-pushed the fiberjw/add-channel-pausing-subcommands branch from 3da7d19 to 6715f4d Compare October 16, 2024 20:37
@FiberJW FiberJW requested a review from quinlanj October 16, 2024 20:49
Copy link

✅ Thank you for adding the changelog entry!

@FiberJW FiberJW marked this pull request as ready for review October 16, 2024 20:49
Copy link

CodeMention:

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

@FiberJW FiberJW merged commit f0b14bf into main Oct 21, 2024
11 checks passed
@FiberJW FiberJW deleted the fiberjw/add-channel-pausing-subcommands branch October 21, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants