[eas-cli] Include debug info in fingerprint metadata #2513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @wschurman and the rest of your teammates on |
wschurman
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
kadikraman
approved these changes
Aug 21, 2024
wschurman
force-pushed
the
@wschurman/08-21-_eas-cli_include_debug_info_in_fingerprint_metadata
branch
from
c3395bf to
393ef6f
Compare
|
Size Change: +428 kB (+0.84%) Total Size: 51.6 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2513 +/- ##
==========================================
- Coverage 52.87% 52.85% -0.01%
==========================================
Files 544 544
Lines 20085 20089 +4
Branches 4096 4098 +2
==========================================
Hits 10617 10617
- Misses 8654 8657 +3
- Partials 814 815 +1 ☔ View full report in Codecov by Sentry. |
szdziedzic
approved these changes
Aug 22, 2024
quinlanj
approved these changes
Aug 22, 2024
wschurman
force-pushed
the
@wschurman/08-21-_eas-cli_include_debug_info_in_fingerprint_metadata
branch
from
393ef6f to
e241e87
Compare
|
✅ Thank you for adding the changelog entry! |
wschurman
deleted the
@wschurman/08-21-_eas-cli_include_debug_info_in_fingerprint_metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://app.graphite.dev/github/pr/expo/eas-build/437/eas-build-job-Add-field-to-fingerprint-metadata-indicating-whether-it-is-a-debug-fingerprint added this field to the build job object.
This PR writes the field as part of the build command.
Note that that PR needs to be landed, published, and updated here for this to work in CI.
How
Update function that generates, uploads, and includes fingerprint info.
Test Plan
Run regular and debug build for app that uses fingerprint, inspect the entity created, see the metadata has the boolean set correctly.