[chore] Enable remaining lint rules and fix lots of bugs

[wschurman]

Why

This is the real PR I wanted to get to: it uses lint to fix a lot of bugs where promises should have been awaited but weren't. This also fixes bugs where a promise was being accidentally used as a boolean rather than the awaited boolean value.

Closes ENG-13213.

How

Apply rules, fix manually.

Test Plan

yarn lint

[wschurman]

• [chore] Enable remaining lint rules and fix lots of bugs #2510 👈
• [chore] Apply more lint #2509
• [chore] Enable more eslint rules to match other expo repos #2508
• [chore] Enable more lint rules to align with other expo codebases #2507
• [chore] Add typescript linting to packages #2505 : 1 other dependent PR (#2506 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (9597ea2) to head (333ea14).
Report is 3 commits behind head on main.

Files	Patch %	Lines
packages/eas-cli/src/commands/update/list.ts	0.00%	3 Missing ⚠️
packages/eas-cli/src/commands/analytics.ts	0.00%	1 Missing ⚠️
...-cli/src/credentials/ios/IosCredentialsProvider.ts	0.00%	1 Missing ⚠️
...ntials/ios/actions/DistributionCertificateUtils.ts	0.00%	1 Missing ⚠️
...ials/ios/validators/validateProvisioningProfile.ts	0.00%	1 Missing ⚠️
...kages/eas-cli/src/credentials/manager/ManageIos.ts	0.00%	1 Missing ⚠️
packages/eas-cli/src/project/publish.ts	83.34%	1 Missing ⚠️
packages/eas-cli/src/run/ios/systemRequirements.ts	0.00%	0 Missing and 1 partial ⚠️
packages/eas-cli/src/user/expoSsoLauncher.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2510      +/-   ##
==========================================
- Coverage   52.95%   52.88%   -0.06%     
==========================================
  Files         544      544              
  Lines       20061    20093      +32     
  Branches     4098     4098              
==========================================
+ Hits        10621    10625       +4     
- Misses       8626     8654      +28     
  Partials      814      814              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Size Change: -289 B (0%)

Total Size: 51.1 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	51.1 MB	-289 B (0%)

_{compressed-size-action}

[linear]

ENG-13213 lint naked promise eas-cli

[sjchmiela]

lol

[szdziedzic]

Thank you, for fixing these! This is a huge improvement 👏

[wschurman]

Merge activity

• Aug 21, 12:11 PM EDT: @wschurman started a stack merge that includes this pull request via Graphite.
• Aug 21, 12:23 PM EDT: Graphite rebased this pull request as part of a merge.
• Aug 21, 12:24 PM EDT: @wschurman merged this pull request with Graphite.

[github-actions]

✅ Thank you for adding the changelog entry!