Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readme source code path #2317

Closed
wants to merge 1 commit into from

Conversation

gabimoncha
Copy link

Why

The README source code link is broken

How

Updated the path of the source code links

Test Plan

Tested by clicking on the updated link path

@szdziedzic
Copy link
Member

Hi @gabimoncha!

Thanks for catching this problem. The one thing you probably need to know about our README is the fact that it is generated automatically during each release. I opened the PR to fix it permanently so the problem won't return in the next release #2318.

Nevertheless, I'm happy to merge this PR!

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Apr 10, 2024
@szdziedzic
Copy link
Member

Go ahead and merge it. Don't worry about https://github.com/expo/eas-cli/actions/runs/8630967051/job/23658414026?pr=2317.

@gabimoncha
Copy link
Author

Thank you @szdziedzic! I missed that part somehow, but makes a lot more sense to have it automated :P

@gabimoncha gabimoncha closed this Apr 22, 2024
@gabimoncha gabimoncha deleted the fix/readme-source-code-path branch April 22, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants