[eas-cli] add --build-logger-level flag to eas build command
#2313
Conversation
|
Size Change: +172 kB (0%) Total Size: 51.6 MB
|
|
/changelog-entry new-feature Add |
szdziedzic
requested review from
EvanBacon,
byCedric and
wschurman
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2313 +/- ##
==========================================
+ Coverage 53.65% 53.68% +0.04%
==========================================
Files 525 525
Lines 19167 19190 +23
Branches 4047 4054 +7
==========================================
+ Hits 10282 10301 +19
- Misses 8158 8162 +4
Partials 727 727 ☔ View full report in Codecov by Sentry. |
| @@ -98,6 +100,10 @@ export default class Build extends EasCommand { | |||
| char: 'm', | |||
| description: 'A short message describing the build', | |||
| }), | |||
| 'build-logger-level': Flags.enum({ | |||
| description: 'The level of logs to output during the build process. Defaults to "info".', | |||
There was a problem hiding this comment.
If we say what it defaults to, should we set the default here? This would also be nicer because we wouldn't need to handle undefined loggerLevel?
There was a problem hiding this comment.
If we set a default here, then every build will have job.loggerLevel specified and then we won't be able to easily control the default logger level for all users server side by changing one const.
szdziedzic
force-pushed
the
@szdziedzic/add-build-logger-level-flag-to-eas-build-command
branch
from
ba040c2 to
3f9339d
Compare
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
@szdziedzic/add-build-logger-level-flag-to-eas-build-command
branch
Why
Companion to https://github.com/expo/universe/pull/14898, https://github.com/expo/turtle-v2/pull/1782 and expo/eas-build#375
We want to allow setting logger level on per build basis to make debugging easier.
How
Add a new
--build-logger-levelflag to theeas buildcommandTest Plan
Test locally