Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project metadata spinner persisting after upload #2311

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

khamilowicz
Copy link
Contributor

Why

Fixes bug where eas build would not exit after build is finished

How

Clear spinner timer

@khamilowicz
Copy link
Contributor Author

/changelog-entry bug-fix Clear spinner timer

@@ -133,6 +133,7 @@ export async function makeProjectMetadataFileAsync(archivePath: string): Promise
}
throw e;
}
clearTimeout(timer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move it to finally? And remove the catch's clearTimeout then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would, on line 180 in makeProjectTarballAsync it is outside finally though.

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/fix-spinner branch from 8b4b190 to 29c823c Compare April 3, 2024 15:09
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.67%. Comparing base (e06fc18) to head (8b4b190).

❗ Current head 8b4b190 differs from pull request most recent head 0f5dcbd. Consider uploading reports for the commit 0f5dcbd to get more accurate results

Files Patch % Lines
packages/eas-cli/src/build/utils/repository.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2311      +/-   ##
==========================================
- Coverage   53.67%   53.67%   -0.00%     
==========================================
  Files         525      525              
  Lines       19159    19160       +1     
  Branches     4043     4043              
==========================================
  Hits        10282    10282              
- Misses       8151     8152       +1     
  Partials      726      726              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 3, 2024

Size Change: +796 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +796 B (0%)

compressed-size-action

@khamilowicz khamilowicz force-pushed the piotrekszeremeta/fix-spinner branch from 29c823c to 0f5dcbd Compare April 3, 2024 15:10
@khamilowicz khamilowicz added the no changelog PR that doesn't require a changelog entry label Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@khamilowicz khamilowicz merged commit b52145c into main Apr 3, 2024
9 of 16 checks passed
@khamilowicz khamilowicz deleted the piotrekszeremeta/fix-spinner branch April 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants