-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project metadata spinner persisting after upload #2311
Conversation
/changelog-entry bug-fix Clear spinner timer |
@@ -133,6 +133,7 @@ export async function makeProjectMetadataFileAsync(archivePath: string): Promise | |||
} | |||
throw e; | |||
} | |||
clearTimeout(timer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to move it to finally
? And remove the catch
's clearTimeout
then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would, on line 180 in makeProjectTarballAsync
it is outside finally
though.
8b4b190
to
29c823c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
- Coverage 53.67% 53.67% -0.00%
==========================================
Files 525 525
Lines 19159 19160 +1
Branches 4043 4043
==========================================
Hits 10282 10282
- Misses 8151 8152 +1
Partials 726 726 ☔ View full report in Codecov by Sentry. |
Size Change: +796 B (0%) Total Size: 51.4 MB
|
29c823c
to
0f5dcbd
Compare
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
Why
Fixes bug where
eas build
would not exit after build is finishedHow
Clear spinner timer