[ENG-11445] Add verbose-fastlane for android builds

expo · Apr 2, 2024 · a3f35a3 · a3f35a3
1 parent 8e95627
commit a3f35a3
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 1 deletion.
diff --git a/packages/eas-cli/src/build/runBuildAndSubmit.ts b/packages/eas-cli/src/build/runBuildAndSubmit.ts
@@ -437,6 +437,7 @@ async function prepareAndStartSubmissionAsync({
     projectId: buildCtx.projectId,
     exp: buildCtx.exp,
     vcsClient: buildCtx.vcsClient,
+    isVerboseFastlaneEnabled: false,
   });
 
   if (moreBuilds) {

diff --git a/packages/eas-cli/src/submit/android/AndroidSubmitter.ts b/packages/eas-cli/src/submit/android/AndroidSubmitter.ts
@@ -112,6 +112,7 @@ export default class AndroidSubmitter extends BaseSubmitter<
       changesNotSentForReview,
       releaseStatus,
       rollout,
+      isVerboseFastlaneEnabled: this.ctx.isVerboseFastlaneEnabled,
       ...serviceAccountKeyResult.result,
     };
   }

diff --git a/packages/eas-cli/src/submit/android/__tests__/AndroidSubmitCommand-test.ts b/packages/eas-cli/src/submit/android/__tests__/AndroidSubmitCommand-test.ts
@@ -123,6 +123,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: true,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -159,6 +160,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -203,6 +205,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -250,6 +253,7 @@ describe(AndroidSubmitCommand, () => {
           changesNotSentForReview: false,
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -312,6 +316,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -372,6 +377,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -439,6 +445,7 @@ describe(AndroidSubmitCommand, () => {
             changesNotSentForReview: false,
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,

diff --git a/packages/eas-cli/src/submit/android/__tests__/ServiceAccountSource-test.ts b/packages/eas-cli/src/submit/android/__tests__/ServiceAccountSource-test.ts
@@ -156,6 +156,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -198,6 +199,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -236,6 +238,7 @@ describe(getServiceAccountKeyResultAsync, () => {
         changesNotSentForReview: false,
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,

diff --git a/packages/eas-cli/src/submit/ios/IosSubmitter.ts b/packages/eas-cli/src/submit/ios/IosSubmitter.ts
@@ -32,7 +32,7 @@ export interface IosSubmissionOptions
   archiveSource: ArchiveSource;
   appSpecificPasswordSource?: AppSpecificPasswordSource;
   ascApiKeySource?: AscApiKeySource;
-  isVerboseFastlaneEnabled: boolean;
+  isVerboseFastlaneEnabled?: boolean;
 }
 
 interface ResolvedSourceOptions {

diff --git a/packages/eas-cli/src/submit/ios/__tests__/AscApiKeySource-test.ts b/packages/eas-cli/src/submit/ios/__tests__/AscApiKeySource-test.ts
@@ -57,6 +57,7 @@ async function getIosSubmissionContextAsync(): Promise<SubmissionContext<Platfor
       language: 'en-US',
     },
     nonInteractive: true,
+    isVerboseFastlaneEnabled: false,
     actor: mockJester,
     graphqlClient,
     analytics,
@@ -249,6 +250,7 @@ describe(getAscApiKeyResultAsync, () => {
         language: 'en-US',
       },
       nonInteractive: true,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,

diff --git a/packages/eas-cli/src/submit/ios/__tests__/IosSubmitCommand-test.ts b/packages/eas-cli/src/submit/ios/__tests__/IosSubmitCommand-test.ts
@@ -100,6 +100,7 @@ describe(IosSubmitCommand, () => {
         ascAppId: '12345678',
       },
       nonInteractive: false,
+      isVerboseFastlaneEnabled: false,
       actor: mockJester,
       graphqlClient,
       analytics,
@@ -134,6 +135,7 @@ describe(IosSubmitCommand, () => {
           language: 'en-US',
         },
         nonInteractive: true,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -169,6 +171,7 @@ describe(IosSubmitCommand, () => {
           ascAppId: '12345678',
         },
         nonInteractive: false,
+        isVerboseFastlaneEnabled: false,
         actor: mockJester,
         graphqlClient,
         analytics,
@@ -231,6 +234,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -288,6 +292,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,
@@ -350,6 +355,7 @@ describe(IosSubmitCommand, () => {
             ascAppId: '12345678',
           },
           nonInteractive: false,
+          isVerboseFastlaneEnabled: false,
           actor: mockJester,
           graphqlClient,
           analytics,