Preserve values with dtype for NumpyOps/CupyOps.asarray #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always specify `dtype` when creating new arrays so that large integer values are preserved and not at risk of going through an intermediate `float64` conversion.
adrianeboyd
added
bug
danieldk
reviewed
Aug 10, 2023
|
@explosion-bot please test_gpu |
URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/111 |
danieldk
added a commit
to danieldk/thinc
that referenced
this pull request
Jan 9, 2024
PR explosion#897 fixed the dtypes in strings2arrays, however also broke strings2arrays for batches with sequences if inequal lengths.
danieldk
added a commit
to danieldk/thinc
that referenced
this pull request
Jan 9, 2024
PR explosion#897 fixed the dtypes in strings2arrays, however also broke strings2arrays for batches with sequences if inequal lengths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always specify
dtypewhen creating new arrays so that large integer values are preserved and not at risk of going through an intermediatefloat64conversion.Types of change
Bug fix.
Checklist