Merge pull request #152 from nexbro/nsec3

fix(nsec3): fixes unset nsec3param not working
exonet · Jun 21, 2024 · 6194a9d · 6194a9d
2 parents e95d400 + e3fd291
commit 6194a9d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Resources/Zone.php b/src/Resources/Zone.php
@@ -353,7 +353,7 @@ public function setNsec3param(?string $nsec3param): self
     {
         // If set to null, return,
         if (is_null($nsec3param)) {
-            $this->nsec3param = null;
+            $this->nsec3param = "";
 
             return $this;
         }

diff --git a/tests/Resources/ZoneTest.php b/tests/Resources/ZoneTest.php
@@ -116,7 +116,7 @@ public function testSetEmptyNsec3param(): void
     {
         $zone = new Zone();
         $zone->setNsec3param(null);
-        $this->assertNull($zone->getNsec3param());
+        $this->assertEmpty($zone->getNsec3param());
     }
 
     public function testSetNsec3paramInvalidAlgorithm(): void

diff --git a/tests/ZoneTest.php b/tests/ZoneTest.php
@@ -271,7 +271,7 @@ public function testSetEmptyNsec3param(): void
         $connector = Mockery::mock(Connector::class);
         $connector->shouldReceive('put')->withArgs(['zones/test.nl.', Mockery::on(function ($transformer) {
             $transformed = $transformer->transform();
-            $this->assertNull($transformed->nsec3param);
+            $this->assertEmpty($transformed->nsec3param);
 
             return true;
         })])->once()->andReturn([]);