Merge pull request #153 from bennetgallein/feat/make-nameservers-auto…

…-canoncial feat: make nameservers auto canoncial
exonet · Sep 9, 2024 · 59dc5d6 · 59dc5d6
2 parents 45eb375 + 0055a27
commit 59dc5d6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/src/Powerdns.php b/src/Powerdns.php
@@ -148,12 +148,8 @@ public function useKey(string $key): PowerdnsInterface
      */
     public function createZone(string $canonicalDomain, array $nameservers, bool $useDnssec = false): Zone
     {
-        $fixDot = substr($canonicalDomain, -1) !== '.';
-
-        if ($fixDot) {
-            $canonicalDomain .= '.';
-        }
 
+        $canonicalDomain = rtrim($canonicalDomain, ".") . ".";
         $newZone = new ZoneResource();
         $newZone->setName($canonicalDomain);
         $newZone->setNameservers($nameservers);

diff --git a/src/Resources/Zone.php b/src/Resources/Zone.php
@@ -453,7 +453,9 @@ public function setApiRectify(bool $apiRectify): self
      */
     public function setNameservers(array $nameservers): self
     {
-        $this->nameservers = $nameservers;
+        $this->nameservers = array_map(function($ns) {
+            return rtrim($ns, '.') . '.';
+        }, $nameservers);
 
         return $this;
     }

diff --git a/tests/Resources/ZoneTest.php b/tests/Resources/ZoneTest.php
@@ -65,11 +65,10 @@ public function testSetApiResponseWithoutOptionalData(): void
         $this->assertNull($zone->getAccount());
     }
 
-    public function testSetNameservers(): void
-    {
+    public function testSetNameserversCanoncial(): void {
         $zone = new Zone();
-        $zone->setNameservers(['foo', 'bar']);
-        $this->assertSame(['foo', 'bar'], $zone->getNameservers());
+        $zone->setNameservers(['ns1', 'ns2']);
+        $this->assertSame(['ns1.', 'ns2.'], $zone->getNameservers());
     }
 
     public function testSetKind(): void