Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync book store #850

Merged
merged 5 commits into from
Dec 8, 2024
Merged

Sync book store #850

merged 5 commits into from
Dec 8, 2024

Conversation

tomasnorre
Copy link
Contributor

Resolves #842

There are some tests failing, with the example configuration. I had tested with my private implementation too, there some fails too.

So I don't know if some tests aren't meant for the PHP track or what the deal is yet.

I Haven't made as detailed descriptions on the additional tests, they were more confusing than helpful to me.

Copy link

github-actions bot commented Nov 8, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 9, 2024
@tomasnorre tomasnorre closed this Nov 14, 2024
@tomasnorre tomasnorre reopened this Nov 14, 2024
@tomasnorre tomasnorre marked this pull request as draft November 14, 2024 17:18
@tomasnorre
Copy link
Contributor Author

tomasnorre commented Nov 14, 2024

Do you see what's wrong in the logic, that makes the two tests fail?

The linting should get a new release that fixes it within the next week.

@tomasnorre tomasnorre marked this pull request as ready for review November 14, 2024 18:12
@tomasnorre
Copy link
Contributor Author

Updated to match how I did it in the go-track, in that way it works.

@tomasnorre tomasnorre requested a review from mk-mxp November 19, 2024 14:37
@mk-mxp
Copy link
Contributor

mk-mxp commented Nov 20, 2024

@tomasnorre FYI: I am short of time until December. Please be patient...

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work! Just a tiny change required.

@tomasnorre tomasnorre requested a review from mk-mxp November 24, 2024 16:11
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience. And thanks for your contribution!

@mk-mxp mk-mxp merged commit 0af034f into exercism:main Dec 8, 2024
12 checks passed
@tomasnorre tomasnorre deleted the sync-book-store branch December 8, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync book-store
2 participants