sync atbash-cipher

[tomasnorre]

Resolves #839

[github-actions]

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

[mk-mxp]

Please add a function stub for decode() to the students file.

Everything else looks great, maybe a small improvement to ease the itches of an array_search() for each character.

[tomasnorre]

Better now?

[tomasnorre]

I cannot reproduce the problem with the composer lint:check locally.

Edit: I can now after an composer update looks like something change in one of the dependencies. I'll try to look into it. It's the same for the Bowling PR #856

[mk-mxp]

It's about to be solved: We should follow PHPCS naming conventions as soon as possible.

If you want to provide a PR fixing it really, use Commenting category like here.

[tomasnorre]

It's about to be solved: We should follow PHPCS naming conventions as soon as possible.

If you want to provide a PR fixing it really, use Commenting category like here.

I just saw it just now too.
Edit: There is already a PR in progress, which solves the problem. PHPCSStandards/PHP_CodeSniffer#676

[tomasnorre]

This can be review PHPCS is working and MacOS fix is rebased into the PR.

[mk-mxp]

Thanks for all the work!