Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: sync binary search #738

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

fejan-malek
Copy link
Contributor

Completed all the todos which is mentioned here.

#731

Also added 2 new missing test cases from problem_specification.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, great work again!

Please wait before doing the next sync task. About 2 weeks before the date in the issue heading is the right time to sync the exercise. Exercism staff updates problem specifications also. So too fast means syncing again.

Happy to see a PR for #732 "spiral-matrix" after 2024-06-24!

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Jun 11, 2024
@mk-mxp mk-mxp merged commit 83e3b16 into exercism:main Jun 11, 2024
13 checks passed
@fejan-malek
Copy link
Contributor Author

Yes sure I will take "spiral-matrix" as a priority after 2024-06-24!

Till then any issue in priority?

@fejan-malek fejan-malek deleted the change-binary-search branch June 11, 2024 08:58
@mk-mxp
Copy link
Contributor

mk-mxp commented Jun 11, 2024

Priority? No, nothing with priority.

We have a list of exercises in issue #684 (at the end, starting with W1 | 2024-01-16 | leap) where syncing is required, but they already were part of the #48in24 challenge. These can be done at any time. I can create issues for each exercise, if you want to do these.

Do you have advanced knowledge of PHP and PHPUnit? There are still some practice exercises missing (see #629). This also requires more knowledge of configlet and the inner workings of Exercism (https://exercism.org/docs/building/tracks/practice-exercises). Before adding one, open a forum discussion in Programming/PHP to discuss which one and how the students interface should look like.

@fejan-malek
Copy link
Contributor Author

Please wait before doing the next sync task. About 2 weeks before the date in the issue heading is the right time to sync the exercise. Exercism staff updates problem specifications also. So too fast means syncing again.

You told me to wait till 2 weeks correct so I can't contribute to any sync task till that time.

Do you have advanced knowledge of PHP and PHPUnit? There are still some practice exercises missing (see #629). This also requires more knowledge of configlet and the inner workings of Exercism

Yes, I am aware of advanced of PHP and even work on frameworks of PHP. And about the PHP unit, I am still getting my hands on it.

So as you suggested me issue is that we have to create a missing exercise is that correct?

@fejan-malek
Copy link
Contributor Author

If you allow me I can work on re-sync of exercise from W1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants