-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: sync binary search #738
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, great work again!
Please wait before doing the next sync task. About 2 weeks before the date in the issue heading is the right time to sync the exercise. Exercism staff updates problem specifications also. So too fast means syncing again.
Happy to see a PR for #732 "spiral-matrix" after 2024-06-24!
Yes sure I will take "spiral-matrix" as a priority after 2024-06-24! Till then any issue in priority? |
Priority? No, nothing with priority. We have a list of exercises in issue #684 (at the end, starting with Do you have advanced knowledge of PHP and PHPUnit? There are still some practice exercises missing (see #629). This also requires more knowledge of |
You told me to wait till 2 weeks correct so I can't contribute to any sync task till that time.
Yes, I am aware of advanced of PHP and even work on frameworks of PHP. And about the PHP unit, I am still getting my hands on it. So as you suggested me issue is that we have to create a missing exercise is that correct? |
If you allow me I can work on re-sync of exercise from W1. |
Completed all the todos which is mentioned here.
#731
Also added 2 new missing test cases from problem_specification.