Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync difference of squares #681

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

mk-mxp
Copy link
Contributor

@mk-mxp mk-mxp commented Apr 7, 2024

This will be the #48in24 exercise on 2024-04-16. Important files changed, but re-running tests on submitted student code not required.

  • Tests included input "10", problem spec had input "1" instead. As the problem is linear, only cheating solutions would fail the changed test suite.
  • Test ordered according to problem spec order.

Closes #676

@mk-mxp mk-mxp requested a review from homersimpsons April 7, 2024 16:08
Copy link

github-actions bot commented Apr 7, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@mk-mxp mk-mxp self-assigned this Apr 7, 2024
@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Apr 7, 2024
Copy link
Contributor

@homersimpsons homersimpsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check the UUIDs. Thank you for the re-ordering of the test to follow specification's order.

@homersimpsons
Copy link
Contributor

@mk-mxp I'm wondering if we have a list of all not-synced exercises (configlet certainly has this).

@mk-mxp
Copy link
Contributor Author

mk-mxp commented Apr 8, 2024

@homersimpsons I made #628 a while ago, and I have assembled a list of dates for #48in24 exercises on my machine. I wanted to extract syncing issues for the #48in24 exercises about 1-2 weeks ahead of their date (not too early, because Exercism re-works the instructions / introductions also just a few days in advance). But I also wanted to write all that into an issue like #630 when I have time these days.

@mk-mxp mk-mxp merged commit 8b5ed50 into exercism:main Apr 8, 2024
11 checks passed
@mk-mxp mk-mxp deleted the sync-difference-of-squares branch April 8, 2024 08:14
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request May 7, 2024
[no important files changed]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#48in24: difference-of-squares 2024-04-16
2 participants