-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Add PHPUnit 10 and PHP 8.3 #656
Conversation
Try: Also, please do not run all OSes and PHP versions, yet. And do not update PHP requirement in |
About the performance problem: My first guess is XDebug. Maybe |
Possible, didn't think about that as I didn't see it activated. Update: You are probably right, it's faster now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, performance is now equal to the older versions. Great step forward!
Thanks a lot for the fiddling with the CI.
No Problem. Working as a DevOps, it's not really new to me. |
I'm not sure how to add the allow failure on GitHub Actions, with GitLab CI I would know how to do it, but to my knowledge it's not supported in GHA yet.
This solves, from my understanding, the first 3 bullets in #652
For some reason, the tests are slower with PHPUnit 10 and PHP 8.3, than PHPUnit 10 and PHP 8.2. I have not dug into that yet, but would be something that would interest me why.
Todo: