Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Secret Handshake Exercise #634

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Add Secret Handshake Exercise #634

merged 3 commits into from
Feb 23, 2024

Conversation

tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre mentioned this pull request Feb 22, 2024
Closed
8 tasks
@mk-mxp mk-mxp mentioned this pull request Feb 22, 2024
Open
28 tasks
@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 22, 2024
mk-mxp
mk-mxp approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice already. If you do not want to add some binary notation: I'm happy to merge it as it is, too.

exercises/practice/secret-handshake/SecretHandshakeTest.php Outdated Show resolved Hide resolved
@mk-mxp
Copy link
Contributor

mk-mxp commented Feb 23, 2024

@tomasnorre Maybe a bit more binary notation here and there? Randomly choose test input, so we get a nice mixture of both notations.

@tomasnorre
Copy link
Contributor Author

@tomasnorre Maybe a bit more binary notation here and there? Randomly choose test input, so we get a nice mixture of both notations.

I can do that. Hold on ;)

mk-mxp
mk-mxp approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Very nice.

@mk-mxp mk-mxp merged commit 2b0ecd7 into exercism:main Feb 23, 2024
12 checks passed
@tomasnorre tomasnorre deleted the add-secret-handshake-exercise branch February 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@tomasnorre tomasnorre

Labels
x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasnorre @mk-mxp