Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example in introduction.md #570

Closed
wants to merge 1 commit into from
Closed

Conversation

aan-t
Copy link
Contributor

@aan-t aan-t commented Oct 26, 2023

A part of the example didn't make too much sense and a comment was misplaced

A part of the example didn't make too much sense and the comment was misplaced
@neenjaw neenjaw added x:type/content Work on content (e.g. exercises, concepts) x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels Oct 26, 2023
@neenjaw
Copy link
Collaborator

neenjaw commented Oct 26, 2023

Thanks

Copy link
Collaborator

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aan-t
Copy link
Contributor Author

aan-t commented Oct 31, 2023

Sure, will create a new PR with those changes included as well. (That's how it works, right? I'm still new to this)
Or should I create an issue for small stuff like this?

@aan-t aan-t closed this Oct 31, 2023
@aan-t aan-t deleted the patch-2 branch October 31, 2023 11:22
@neenjaw
Copy link
Collaborator

neenjaw commented Oct 31, 2023

You don’t have to close it. If you are using GitHub as an editor, you can edit the next page and select your branch to apply the changes to, Willis will update this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants