Skip to content

Commit

Permalink
Adjust to feedback from review - Iteration 1
Browse files Browse the repository at this point in the history
  • Loading branch information
tomasnorre committed Feb 22, 2024
1 parent d240a55 commit 24dd32c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 22 deletions.
22 changes: 0 additions & 22 deletions exercises/practice/kindergarten-garden/.meta/example.php
Original file line number Diff line number Diff line change
@@ -1,27 +1,5 @@
<?php

/*
* By adding type hints and enabling strict type checking, code can become
* easier to read, self-documenting and reduce the number of potential bugs.
* By default, type declarations are non-strict, which means they will attempt
* to change the original type to match the type specified by the
* type-declaration.
*
* In other words, if you pass a string to a function requiring a float,
* it will attempt to convert the string value to a float.
*
* To enable strict mode, a single declare directive must be placed at the top
* of the file.
* This means that the strictness of typing is configured on a per-file basis.
* This directive not only affects the type declarations of parameters, but also
* a function's return type.
*
* For more info review the Concept on strict type checking in the PHP track
* <link>.
*
* To disable strict typing, comment out the directive below.
*/

declare(strict_types=1);

class KindergartenGarden
Expand Down
5 changes: 5 additions & 0 deletions exercises/practice/kindergarten-garden/KindergartenGarden.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@

class KindergartenGarden
{
public function __construct(string $diagram)
{
throw new \BadMethodCallException(sprintf('Implement the %s method', __FUNCTION__));
}

public function plants(string $student): array
{
throw new \BadMethodCallException(sprintf('Implement the %s method', __FUNCTION__));
Expand Down

0 comments on commit 24dd32c

Please sign in to comment.