Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zindex #27

Merged
merged 1 commit into from
Oct 24, 2020
Merged

zindex #27

merged 1 commit into from
Oct 24, 2020

Conversation

choldgraf
Copy link
Member

closes #23

@choldgraf
Copy link
Member Author

choldgraf commented Oct 24, 2020 •
edited
Loading

@mgeier look OK to you?

image

@mgeier
Copy link
Contributor

mgeier commented Oct 24, 2020

Looks great!

@choldgraf choldgraf merged commit b2c3510 into master Oct 24, 2020
@choldgraf
Copy link
Member Author

@mgeier I cut a release as well in case you'd like to use this

@mgeier
Copy link
Contributor

mgeier commented Oct 25, 2020

Thanks a lot! It's not urgent though. I was just playing around with it in preparation for continuing work on spatialaudio/nbsphinx#436. But that has time ...

I'd still need #26 to be fixed anyway.

Also, there are some minor button CSS issues when using other themes, I guess I'll open a new issue for that in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Isn't z-index: 999 a bit excessive?
2 participants
@choldgraf @mgeier