👌 Throw an error if 3rd party plugin doesn't increment line or pos counters
#336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the commit message got somehow malformed when copy pasting a message with backticks to to terminal. Perhaps best to squash and merge with the PRs (or other) message. |
chrisjsewell
reviewed
Nov 2, 2024
| @@ -91,25 +91,24 @@ def fromCodePoint(c: int) -> str: | |||
| r'\\([!"#$%&\'()*+,\-.\/:;<=>?@[\\\]^_`{|}~])' + "|" + r"&([a-z#][a-z0-9]{1,31});", | |||
| re.IGNORECASE, | |||
| ) | |||
| DIGITAL_ENTITY_BASE10_RE = re.compile(r"#([0-9]{1,8})") | |||
| DIGITAL_ENTITY_BASE16_RE = re.compile(r"#x([a-f0-9]{1,8})", re.IGNORECASE) | |||
| DIGITAL_ENTITY_TEST_RE = re.compile( | |||
There was a problem hiding this comment.
This change seems separate to the PR title?
Can you split it into a separate PR
There was a problem hiding this comment.
Most changes here are unrelated refactors actually. This is a port of the diff in the first post. Should something else be split too?
There was a problem hiding this comment.
Yeh ideally it should be split up fully into "logical changes" 😅
There was a problem hiding this comment.
👍 Pushed a new commit history. Would this split work?
hukkin
force-pushed
the
sync-upstream-commit-49ca65b
branch
from
2126aeb
to
fe0e4e7
Compare
…` counters (previously infinite loop would likely occur)
hukkin
force-pushed
the
sync-upstream-commit-49ca65b
branch
from
fe0e4e7
to
ddf1634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(previously, markdown-it would likely go into infinite loop instead)
This really is a port of upstream changes markdown-it/markdown-it@13.0.1...49ca65b which adds up to just one changelog entry (the PR title).