Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tag support for including tags in the exceptionless feed #18

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

dnoakes
Copy link
Contributor

@dnoakes dnoakes commented Jul 23, 2024

Example usage,

Serilog: Log.ForContext("Tags", new List() { "Tag1", "Tag2"}).Information("Seri info");
ILogger:
using (var scope = _logger.BeginScope(new Dictionary<string, object> { ["Tags"] = new string[] { "Test1", "Test2" }}))
{
_logger.Log(logLevel, eventId, state, exception, formatter);
}

image

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@niemyjski
Copy link
Member

niemyjski commented Jul 24, 2024

Thanks for the PR! I've left a comment on the tags implementation. I wonder if it's worth supporting other first-class properties like value as well.

@niemyjski niemyjski merged commit d71d3f8 into exceptionless:master Jul 24, 2024
4 checks passed
@niemyjski
Copy link
Member

Thanks again for the PR. I just published https://github.com/exceptionless/serilog-sinks-exceptionless/releases/tag/v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants