Change to show milliseconds when total time is less than 2 seconds

exceptionless · Apr 16, 2020 · af7d086 · af7d086
1 parent b7985b8
commit af7d086
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 13 deletions.
diff --git a/.vscode/tasks.json b/.vscode/tasks.json
@@ -12,7 +12,8 @@
       "args": [
         "build",
         "${workspaceFolder}",
-        "/p:GenerateFullPaths=true"
+        "/p:GenerateFullPaths=true",
+        "/consoleloggerparameters:NoSummary"
       ],
       "problemMatcher": "$msCompile"
     },
@@ -27,7 +28,8 @@
       "args": [
         "test",
         "${workspaceFolder}",
-        "/p:GenerateFullPaths=true"
+        "/p:GenerateFullPaths=true",
+        "/consoleloggerparameters:NoSummary"
       ],
       "problemMatcher": "$msCompile"
     },

diff --git a/src/Exceptionless.DateTimeExtensions/TimeSpanExtensions.cs b/src/Exceptionless.DateTimeExtensions/TimeSpanExtensions.cs
@@ -148,14 +148,20 @@ public string ToString(int maxParts, bool shortForm = false, bool includeMillise
             if (seconds > 10)
                 seconds = Math.Round(seconds);
 
-            if (AppendPart(sb, "second", seconds, shortForm, ref partCount))
-                if (maxParts > 0 && partCount >= maxParts)
-                    return sb.ToString();
-
-            if (includeMilliseconds && AppendPart(sb, "millisecond", Milliseconds, shortForm, ref partCount))
-                if (maxParts > 0 && partCount >= maxParts)
-                    return sb.ToString();
-
+            if (Math.Abs(TotalSeconds) > 2) {
+                if (AppendPart(sb, "second", seconds, shortForm, ref partCount))
+                    if (maxParts > 0 && partCount >= maxParts)
+                        return sb.ToString();
+
+                if (includeMilliseconds && AppendPart(sb, "millisecond", Milliseconds, shortForm, ref partCount))
+                    if (maxParts > 0 && partCount >= maxParts)
+                        return sb.ToString();
+            } else {
+                if (AppendPart(sb, "millisecond", TotalMilliseconds, shortForm, ref partCount))
+                    if (maxParts > 0 && partCount >= maxParts)
+                        return sb.ToString();
+            }
+
             return sb.ToString();
         }
 

diff --git a/tests/Exceptionless.DateTimeExtensions.Tests/TimeSpanExtensionTests.cs b/tests/Exceptionless.DateTimeExtensions.Tests/TimeSpanExtensionTests.cs
@@ -6,13 +6,13 @@ public class TimeSpanExtensionTests {
         [Fact]
         public void ToWords() {
             TimeSpan value = TimeSpan.FromMilliseconds(100);
-            Assert.Equal("0.1 second", value.ToWords());
+            Assert.Equal("100 milliseconds", value.ToWords());
 
             value = TimeSpan.FromMilliseconds(-100);
-            Assert.Equal("-0.1 second", value.ToWords());
+            Assert.Equal("-100 milliseconds", value.ToWords());
 
             value = TimeSpan.FromMilliseconds(100);
-            Assert.Equal("0.1s", value.ToWords(true));
+            Assert.Equal("100ms", value.ToWords(true));
 
             value = TimeSpan.FromMilliseconds(2500);
             Assert.Equal("2.5 seconds", value.ToWords());