-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#992: added design doc for script options #477
Open
tomuben
wants to merge
18
commits into
master
Choose a base branch
from
doc/992_add_design_doc_for_script_options
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d2c2f6e
#991: Added Design Doc and Requirements Doc for Script Options parser
tomuben 9385004
Updated design document
tomuben 6c4c049
Updated design document
tomuben b9a7904
Updated design document
tomuben 2b1e472
Updated design document
tomuben 9671883
Updated design document & requirements document
tomuben 93dca60
Added a GH workflow to run
tomuben 9e35421
Fixed oft.yaml
tomuben 3911606
Fixed oft.yaml
tomuben d0fee61
Fixed oft.yaml
tomuben a2fcff1
Fixed oft.yaml
tomuben 7910608
Fixed oft.yaml
tomuben 24caddc
Fixed oft.yaml
tomuben 14425fa
Removed `Needs: req` in script_options_design.md
tomuben 6800239
Fixed findings from OFT
tomuben 1f08f8d
Fixed findings from OFT
tomuben 207e27f
Fixed findings from review
tomuben af0d8ee
Merge branch 'master' into doc/992_add_design_doc_for_script_options
tomuben File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: OFT Report | ||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
pull_request: | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-24.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Run HTML Report | ||
run: | | ||
bash .github/workflows/scripts/run_oft.sh ./exaudfclient base -o html -f ./oft_report.html -t V2,_ || echo failed | ||
- name: Run Plaintext Report | ||
run: | | ||
bash .github/workflows/scripts/run_oft.sh ./exaudfclient base -t V2,_ | ||
- uses: actions/upload-artifact@v4 | ||
if: always() | ||
with: | ||
name: "oft_report.html" | ||
path: oft_report.html |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#!/bin/bash | ||
|
||
set -o errexit | ||
set -o nounset | ||
set -o pipefail | ||
|
||
oft_version="4.1.0" | ||
|
||
base_dir="$1" | ||
shift 1 | ||
src_dir="$1" | ||
shift 1 | ||
additional_options=$@ | ||
readonly base_dir | ||
readonly oft_jar="$HOME/.m2/repository/org/itsallcode/openfasttrace/openfasttrace/$oft_version/openfasttrace-$oft_version.jar" | ||
|
||
if [ ! -f "$oft_jar" ]; then | ||
echo "Downloading OpenFastTrace $oft_version" | ||
mvn --batch-mode org.apache.maven.plugins:maven-dependency-plugin:3.3.0:get -Dartifact=org.itsallcode.openfasttrace:openfasttrace:$oft_version | ||
fi | ||
|
||
# Trace all | ||
java -jar "$oft_jar" trace \ | ||
$additional_options \ | ||
-a feat,req,dsn \ | ||
"$base_dir/docs" \ | ||
"$base_dir/$src_dir" |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25.9 KB
exaudfclient/docs/diagrams/OveralScriptOptionalsBuildingBlocks.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+13.4 KB
exaudfclient/docs/diagrams/ScriptOptionsExtractorInterface.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+40.9 KB
exaudfclient/docs/diagrams/ScriptOptionsParserHandlerSequence.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should at some Point replace this with a nox session, please create an issue