#990: refactor script options parser #468
Conversation
1. Splitted up Converter into Legacy and V2 2. Splitted up Extractor into Interface and Implementation 3. JavaContainerBuilder now instantiates Extractor instead of parser.
2. Removed unnecessary include in parser_ctpg.cc
There was a problem hiding this comment.
Tests for ConverterLegacy and ConverterV2 are currently the same.
exaudfclient/base/javacontainer/script_options/converter_legacy.cc
Outdated
Show resolved
Hide resolved
| const std::set<std::string> & getJarPaths() const { | ||
| return m_jarPaths; | ||
| } |
There was a problem hiding this comment.
Often, it is sufficient to expose only iterators rather than the full underlying (internal) data structure.
There was a problem hiding this comment.
This function will change in a future PR completely. I only wanted to keep the size of the PR as small as possible.
exaudfclient/base/javacontainer/script_options/converter_legacy.cc
Outdated
Show resolved
Hide resolved
| void ConverterV2::convertExternalJar(const std::string & value) { | ||
| std::istringstream stream(value); | ||
| std::string jar; | ||
|
|
||
| while (std::getline(stream, jar, ':')) { | ||
| m_jarPaths.insert(jar); // If m_jarPaths is a Set or you make it a Set, uniqueness implicitly is taken care of | ||
| } |
There was a problem hiding this comment.
I think now it is duplicated .cc and in the .h there is the same impl.
There was a problem hiding this comment.
No, this is the other implementation. In the next PR I will change the implementation in ConverterV2
| std::string jar; | ||
|
|
||
| while (std::getline(stream, jar, ':')) { | ||
| m_jarPaths.insert(jar); |
There was a problem hiding this comment.
The trimming happens in the Parser, or?
There was a problem hiding this comment.
Yes, here
Also there is unit test ensuring that we don't change the behavior:
exasol/script-languages-release#990