#983: Refactor CTPG script options Java parser code #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicoretti
reviewed
Oct 18, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.h
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Outdated
Show resolved
Hide resolved
Nicoretti
previously approved these changes
Oct 18, 2024
tkilias
reviewed
Oct 18, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 18, 2024
exaudfclient/base/javacontainer/script_options/parser_ctpg_script_importer.cc
Outdated
Show resolved
Hide resolved
tkilias
reviewed
Oct 18, 2024
| scriptCode.replace(optionIt->origPos, optionIt->origLen, optionIt->script); | ||
| } | ||
| collectImportScripts(optionIt->second, recursionDepth, collectedScript); | ||
| //Now replace the imported script bodies |
There was a problem hiding this comment.
Suggested change
| //Now replace the imported script bodies |
tkilias
reviewed
Oct 18, 2024
| std::vector<ReplacedScripts> replacedScripts; | ||
| replacedScripts.reserve(optionIt->second.size()); | ||
| std::vector<CollectedScript> collectedScript; | ||
| collectedScript.reserve(optionIt->second.size()); | ||
| //In order to continue compatibility with legacy implementation we must collect import scripts in forward direction |
There was a problem hiding this comment.
this should probably go into collectImportScripts
There was a problem hiding this comment.
Hm, the comment is about both steps:
collectImportScripts() + ``replaceImportScripts`. I think it's better to keep it here
tkilias
reviewed
Oct 18, 2024
| std::vector<ReplacedScripts> replacedScripts; | ||
| replacedScripts.reserve(optionIt->second.size()); | ||
| std::vector<CollectedScript> collectedScript; | ||
| collectedScript.reserve(optionIt->second.size()); | ||
| //In order to continue compatibility with legacy implementation we must collect import scripts in forward direction | ||
| //but then replace in reverse direction (in order to keep consistency of positions) |
There was a problem hiding this comment.
this one is already in replaceImportScripts
There was a problem hiding this comment.
Removed
(in order to keep consistency of positions)
Nicoretti
approved these changes
Oct 21, 2024
tkilias
approved these changes
Oct 21, 2024
tomuben
deleted the
refactoring/983_refactor_ctpg_script_options_java_parser_code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#983