#973: Support new lines and white spaces at the beginning in script options values #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkilias
reviewed
Oct 10, 2024
exaudfclient/base/script_options_parser/ctpg/script_option_lines_ctpg.cc
Show resolved
Hide resolved
tomuben
force-pushed
the
refactoring/973_support_new_lines_in_ctpg_script_options
branch
from
0268a87 to
987b1cf
Compare
tkilias
reviewed
Oct 10, 2024
| option_value(option_value, not_semicolon) | ||
| >= [](auto&& ov, auto v) { return std::move(ov.append(v.get_value())); }, | ||
| option_value(option_value, semicolon_escape) | ||
| >= [](auto&& ov, auto v) { return std::move(ov.append(";")); }, | ||
| option_value(option_value, whitespace_escape_seq) |
There was a problem hiding this comment.
in theory, only the first whitespace needs escaping what are we doing now.
There was a problem hiding this comment.
YEs, that's the implementation. But as the lexer will detect the escaped white spaces, I need to handle this case here, so that the escaped white spaces are added "as is" to the option value. Please have a look to the test:
There was a problem hiding this comment.
ah, overlooked that, you are right
tkilias
changed the title
tkilias
changed the title
tkilias
approved these changes
Oct 10, 2024
tomuben
deleted the
refactoring/973_support_new_lines_in_ctpg_script_options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to exasol/script-languages-release#973