Skip to content

Commit

Permalink
Fixed findings from OFT
Browse files Browse the repository at this point in the history
  • Loading branch information
tomuben committed Nov 15, 2024
1 parent 721dc4d commit 99f4ddf
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 13 deletions.
34 changes: 22 additions & 12 deletions exaudfclient/docs/script_options_design.md
Original file line number Diff line number Diff line change
Expand Up @@ -317,13 +317,12 @@ Covers:
Tags: V2

### Unknown Options Check
`req~script-option-unknown-options-behvaior-v2~1`

Implement a check which verifies that only known script options are found. Otherwise, raise an exception with information about the position and name of the unknown option.
`dsn~script-option-unknown-options-behvaior-v2~1`

Implement a check in class `ScriptOptionLinesParserCTPG` which verifies that only known script options are found. Otherwise, raise an exception with information about the position and name of the unknown option.

Covers:
- `req~script-option-removal~1`
- `req~script-option-unknown-options-behavior-v2~1`

Tags: V2

Expand All @@ -334,7 +333,7 @@ Implement a function in the `Converter` class which adds the script class option


Covers:
- `req~java-scriptclass-option-handling~1`
- `req~java-scriptclass-option-handling-v2~1`

Tags: V2

Expand Down Expand Up @@ -374,6 +373,21 @@ Covers:

Tags: V2

### Java %jvmoption Whitespace Handling
`dsn~java-jvmoption-whitespace-handling~1`

Define the Lexer rules to tokenize whitespace sequences.
Implement rules which split JVM options by those token.


Depends:
- `dsn~java-jvmoption-handling~1`

Covers:
- `req~java-jvmoption-whitespace-handling~1`

Tags: V2

### Java %jvmoption Whitespace Escape Handling
`dsn~java-jvmoption-whitespace-esacape-handling~1`

Expand All @@ -385,13 +399,11 @@ Define the Lexer rules to tokenize whitespace escape sequences:

Implement rules which replace those white space escape tokens which are part of a Jvm option.



Depends:
- `req~java-jvmoption-handling~1`
- `dsn~java-jvmoption-handling~1`

Covers:
- `req~java-jvmoption-whitespace-handling~1`
- req~java-jvmoption-whitespace-escape-handling-v2~1

Tags: V2

Expand All @@ -404,8 +416,6 @@ The algorithm should work according to [section CTPG based Script Import Algori

Covers:
- `req~java-import-option-replace-referenced-scripts~1`
- `feat~java-specific-script-options~1`
- `feat~java-specific-script-options~1`

Tags: V2

Expand Down Expand Up @@ -444,4 +454,4 @@ The performance must not be slower than the old implementation.

##### Mitigation

`dsn~ignore-lines-without-script-options~1` tries to mitigate this risk.
Design decision `dsn~ignore-lines-without-script-options~1` tries to mitigate this risk.
2 changes: 1 addition & 1 deletion exaudfclient/docs/script_options_requirments.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ Covers:
Tags: V1

### Script Option Unknown Options Behavior V2
`req~script-option-unknown-options-behvaior-v2~1`
`req~script-option-unknown-options-behavior-v2~1`

The parser handler must detect unknown script options and throw an exception if such an options is found.

Expand Down

0 comments on commit 99f4ddf

Please sign in to comment.