Skip to content

Commit

Permalink
1. Fixed names in coverter_test.cc
Browse files Browse the repository at this point in the history
2. Removed unnecessary include in parser_ctpg.cc
  • Loading branch information
tomuben committed Oct 23, 2024
1 parent 4418b3d commit 62872d0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#include "base/utils/exceptions.h"
#include "base/script_options_parser/exception.h"
#include "base/swig_factory/swig_factory.h"
#include "base/javacontainer/script_options/string_ops.h"
#include <sstream>


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
using namespace SWIGVMContainers::JavaScriptOptions;


class ConverterJarTest : public ::testing::TestWithParam<std::pair<std::string, std::set<std::string>>> {};
class LegacyConverterJarTest : public ::testing::TestWithParam<std::pair<std::string, std::set<std::string>>> {};

TEST_P(ConverterJarTest, jar) {
TEST_P(LegacyConverterJarTest, jar) {
const std::pair<std::string, std::set<std::string>> option_value = GetParam();
const std::string jar_option_value = option_value.first;

Expand All @@ -27,15 +27,15 @@ const std::vector<std::pair<std::string, std::set<std::string>>> jar_strings =

INSTANTIATE_TEST_SUITE_P(
Converter,
ConverterJarTest,
LegacyConverterJarTest,
::testing::ValuesIn(jar_strings)
);



class ConverterJarEscapeSequenceTest : public ::testing::TestWithParam<std::pair<std::string, std::set<std::string>>> {};
class ConverterV2JarTest : public ::testing::TestWithParam<std::pair<std::string, std::set<std::string>>> {};

TEST_P(ConverterJarEscapeSequenceTest, jar) {
TEST_P(ConverterV2JarTest, jar) {
const std::pair<std::string, std::set<std::string>> option_value = GetParam();
const std::string jar_option_value = option_value.first;
std::cerr << "DEBUG: " << jar_option_value << std::endl;
Expand All @@ -54,6 +54,6 @@ const std::vector<std::pair<std::string, std::set<std::string>>> jar_escape_sequ

INSTANTIATE_TEST_SUITE_P(
Converter,
ConverterJarEscapeSequenceTest,
ConverterV2JarTest,
::testing::ValuesIn(jar_escape_sequences)
);

0 comments on commit 62872d0

Please sign in to comment.