#239: Changed return type for deploy API method #240
Conversation
There was a problem hiding this comment.
mostly a copy of https://github.com/exasol/script-languages-container-tool/blob/main/exasol/slc/internal/tasks/upload/upload_container_base_task.py. Only return type differs
There was a problem hiding this comment.
mostly a copy of https://github.com/exasol/script-languages-container-tool/blob/main/exasol/slc/internal/tasks/upload/upload_container_task.py only base class is different
There was a problem hiding this comment.
mostly a copy of https://github.com/exasol/script-languages-container-tool/blob/main/exasol/slc/internal/tasks/upload/upload_container_tasks_creator.py only created task is different
There was a problem hiding this comment.
exasol/slc/models/deploy_result.py
Outdated
| @dataclass | ||
| class DeployResult: | ||
| release_path: str | ||
| upload_url: str |
There was a problem hiding this comment.
Maybe we want to make this SaaS BucketFS compatible, maybe we actually return a BucketFS PathLike
There was a problem hiding this comment.
I can return both for now. The BucketFS Pathlike has some limitiations as we have seen.
fixes #239