-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily adding the container deployment #98
Merged
ahsimb
merged 9 commits into
main
from
refactoring/97-prepare-container-deployment-migration
Dec 14, 2023
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9f3d5ef
Added language container deployment
ahsimb 52649a1
Updated release_droid_upload_github_release_assets.yml
ahsimb 6059410
[run aws tests]
ahsimb 0c5b4ca
Update doc/changes/changes_0.6.0.md
ahsimb 780823c
Update release_language_container.sh
ahsimb f4c2a2b
Update release_language_container.sh
ahsimb 03f6b91
Addressing review comments [run aws tests]
ahsimb ab821f9
Addressing more review comments
ahsimb 417fddf
Addressing more review comments
ahsimb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# SageMaker Extension 0.6.0, released 2023-12-14 | ||
|
||
Code name: Added language container deployment | ||
|
||
## Summary | ||
|
||
This release includes api and cli for language container deployment. This is now consistent with | ||
similar features of the Transformers extension. | ||
|
||
**Note**: Most of the language container deployment code will be moved eventually to the | ||
script-language-container-tool repository. | ||
|
||
### Features | ||
|
||
n/a | ||
|
||
### Bug Fixes | ||
|
||
n/a | ||
|
||
### Documentation | ||
|
||
n/a | ||
|
||
### Refactoring | ||
|
||
- #97: Improving the container deployment using the container deployer from [transformers-extension](https://github.com/exasol/transformers-extension/) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import logging | ||
import click | ||
from exasol_sagemaker_extension.deployment.deploy_cli import main as scripts_deployer_main | ||
from exasol_sagemaker_extension.deployment.language_container_deployer_cli \ | ||
import language_container_deployer_main, slc_parameter_formatters, CustomizableParameters | ||
from exasol_sagemaker_extension.deployment.sme_language_container_deployer import SmeLanguageContainerDeployer | ||
|
||
|
||
@click.group() | ||
def main(): | ||
pass | ||
|
||
|
||
slc_parameter_formatters.set_formatter(CustomizableParameters.container_url, | ||
SmeLanguageContainerDeployer.SLC_URL_FORMATTER) | ||
slc_parameter_formatters.set_formatter(CustomizableParameters.container_name, | ||
SmeLanguageContainerDeployer.SLC_NAME) | ||
|
||
main.add_command(scripts_deployer_main) | ||
main.add_command(language_container_deployer_main) | ||
|
||
|
||
if __name__ == '__main__': | ||
logging.basicConfig( | ||
format='%(asctime)s - %(module)s - %(message)s', | ||
level=logging.DEBUG) | ||
|
||
main() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the quick installation, we should actually use a proper default value for --version. However, this is a topic for a later ticket.