#142 Made unified deployment #143

ahsimb · 2024-10-10T10:19:00Z

closes #142

tkilias · 2024-10-11T09:49:50Z

exasol_sagemaker_extension/deploy.py

+            container_url_arg=CONTAINER_URL_ARG,
+            container_name_arg=CONTAINER_NAME_ARG)
+
+        extra_params = {StdParams.language_alias.name: 'PYTHON3_SME'}


Ah, ok you hard code the alias for the moment. Until we fixed the script templates that should be good enough.

Yes, exactly

tkilias · 2024-10-11T09:55:24Z

exasol_sagemaker_extension/deployment/language_container.py



 if __name__ == '__main__':
-    export_slc()
+    with export_slc(sys.argv[1]):


Ah, as a quick workaround, because we don't have nox yet setup

Yes, basically it was like this before. I just changed the export_slc function slightly for the convenience of testing.

#142 Made unified deployment

2be34dd

ahsimb added the refactoring Code improvement without behavior change label Oct 10, 2024

ahsimb self-assigned this Oct 10, 2024

ahsimb had a problem deploying to slow-tests October 10, 2024 10:19 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 10:19 — with GitHub Actions Failure

ahsimb had a problem deploying to slow-tests October 10, 2024 10:50 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 10:50 — with GitHub Actions Failure

#142 Fixed param_decls of the extra options

20cd42c

ahsimb had a problem deploying to slow-tests October 10, 2024 11:26 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 11:26 — with GitHub Actions Failure

#142 Passing the language_alias to the slc deployer

71f0d2d

ahsimb had a problem deploying to slow-tests October 10, 2024 11:55 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 11:55 — with GitHub Actions Failure

#142 Fixed deployment tests

b1a247d

ahsimb had a problem deploying to slow-tests October 10, 2024 12:15 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 12:15 — with GitHub Actions Failure

#142 Fixed deployment tests

8f3b885

ahsimb had a problem deploying to slow-tests October 10, 2024 12:45 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 12:46 — with GitHub Actions Failure

#142 Fixed deployment tests

8da2d04

ahsimb had a problem deploying to slow-tests October 10, 2024 13:09 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 13:10 — with GitHub Actions Failure

#142 Fixed deploy function

a702701

ahsimb had a problem deploying to slow-tests October 10, 2024 13:39 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 13:39 — with GitHub Actions Failure

#142 Fixed deploy test

79d3ec7

ahsimb had a problem deploying to slow-tests October 10, 2024 14:22 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 14:22 — with GitHub Actions Failure

#142 Added debugging to deploy

d4ae603

ahsimb had a problem deploying to slow-tests October 10, 2024 15:30 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 15:30 — with GitHub Actions Failure

#142 Added debugging to deploy

8a85840

ahsimb had a problem deploying to slow-tests October 10, 2024 15:51 — with GitHub Actions Failure

ahsimb temporarily deployed to aws October 10, 2024 15:51 — with GitHub Actions Inactive

#142 Fixed the deployer test

63dffd6

ahsimb had a problem deploying to slow-tests October 10, 2024 19:41 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 10, 2024 19:41 — with GitHub Actions Failure

#142 Removed debugging

1253f59

ahsimb had a problem deploying to slow-tests October 11, 2024 07:09 — with GitHub Actions Failure

ahsimb had a problem deploying to aws October 11, 2024 07:09 — with GitHub Actions Failure

#142 Fixed language_container.py

c85fa20

ahsimb temporarily deployed to slow-tests October 11, 2024 07:43 — with GitHub Actions Inactive

ahsimb temporarily deployed to aws October 11, 2024 07:43 — with GitHub Actions Inactive

#142 Restored disk cleaning.

89bb6e1

tkilias reviewed Oct 11, 2024

View reviewed changes

tkilias previously approved these changes Oct 11, 2024

View reviewed changes

ahsimb had a problem deploying to aws October 11, 2024 10:01 — with GitHub Actions Failure

ahsimb dismissed tkilias’s stale review via 52d70a0 October 11, 2024 10:24

ahsimb temporarily deployed to slow-tests October 11, 2024 10:24 — with GitHub Actions Inactive

ahsimb temporarily deployed to aws October 11, 2024 10:24 — with GitHub Actions Inactive

ahsimb temporarily deployed to aws October 11, 2024 10:25 — with GitHub Actions Inactive

#142 Fixed ci tests

52d70a0

tkilias approved these changes Oct 11, 2024

View reviewed changes

ahsimb merged commit 6ddd208 into main Oct 11, 2024
7 checks passed

ahsimb deleted the refactoring/142-unified-cli branch October 11, 2024 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#142 Made unified deployment #143

#142 Made unified deployment #143

ahsimb commented Oct 10, 2024

tkilias Oct 11, 2024 •

edited

Loading

ahsimb Oct 11, 2024

tkilias Oct 11, 2024

ahsimb Oct 11, 2024

#142 Made unified deployment #143

#142 Made unified deployment #143

Conversation

ahsimb commented Oct 10, 2024

tkilias Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

ahsimb Oct 11, 2024

Choose a reason for hiding this comment

tkilias Oct 11, 2024

Choose a reason for hiding this comment

ahsimb Oct 11, 2024

Choose a reason for hiding this comment

tkilias Oct 11, 2024 •

edited

Loading