Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context forwarding for integration test hook plugins #302

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Fix context forwarding for integration test hook plugins #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a310294
Fix context forwarding for integration test hook plugins
Nicoretti Dec 4, 2024
a048fb2
Merge branch 'main' into fix/context-forwarding
Nicoretti Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/changes/unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
## 🐞 Fixed

* Fixed syntax error in the `check.yml` template which resulted in an invalid workflow file
* Fixed context forwarding to plugins hooking into `pre` and `post` integration test hooks
- `pre_integration_tests_hook(self, session, config, context)`
- `post_integration_tests_hook(self, session, config, context)`

## 📚 Documentation

Expand Down
4 changes: 2 additions & 2 deletions exasol/toolbox/nox/_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ def _integration_tests(
pm = NoxTasks.plugin_manager(config)

# run pre integration test plugins
pm.hook.pre_integration_tests_hook(session=session, config=config, context={})
pm.hook.pre_integration_tests_hook(session=session, config=config, context=context)

# run
command = _test_command(config.root / "test" / "integration", config, context)
session.run(*command)

# run post integration test plugins
pm.hook.post_integration_tests_hook(session=session, config=config, context={})
pm.hook.post_integration_tests_hook(session=session, config=config, context=context)


def _pass(
Expand Down
Loading