Skip to content

Commit

Permalink
resolve conversation
Browse files Browse the repository at this point in the history
  • Loading branch information
Jannis-Mittenzwei committed Nov 29, 2024
1 parent 33ab812 commit a270cd8
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 18 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,7 @@ jobs:

Format:
name: Format Check (Python-${{ matrix.python-version }})
needs: [ Version-Check ]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [ "3.9" ]

steps:
- name: SCM Checkout
Expand All @@ -133,7 +128,7 @@ jobs:
- name: Setup Python & Poetry Environment
uses: ./.github/actions/python-environment
with:
python-version: ${{ matrix.python-version }}
python-version: "3.9"

- name: Run format check
run: poetry run nox -s project:format
Expand Down
4 changes: 2 additions & 2 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
* Excluded pyupgrade from project check due to its destructive nature
* Updated cookiecutter template
- removed obsolete template file `version.html`
* added nox task for format checking
* Updated github workflow template checks.yml
* Added nox task for format checking
* Updated GitHub workflow and workflow template of `checks.yml` to include format check

## 🐞 Fixed

Expand Down
1 change: 1 addition & 0 deletions exasol/toolbox/nox/_format.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,6 @@ def fix(session: Session) -> None:

@nox.session(name="project:format", python=False)
def fmt_check(session: Session) -> None:
"""Checks the project for correct formatting"""
py_files = [f"{file}" for file in python_files(PROJECT_CONFIG.root)]
_code_format(session=session, mode=Mode.Check, files=py_files)
8 changes: 1 addition & 7 deletions exasol/toolbox/templates/github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,7 @@ jobs:

Format:
name: Format Check (Python-${{ matrix.python-version }})
needs: [ Version-Check ]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
python-version: [ "3.9" ]

steps:
- name: SCM Checkout
Expand All @@ -139,8 +134,7 @@ jobs:
- name: Setup Python & Poetry Environment
uses: exasol/python-toolbox/.github/actions/[email protected]
with:
python-version: ${{ matrix.python-version }}

python-version: "3.9"
- name: Run format check
run: poetry run nox -s project:format

Expand Down
6 changes: 3 additions & 3 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a270cd8

Please sign in to comment.