Fix double execution of CI workflow on initial PR push

exasol · Dec 18, 2024 · 92d5139 · 92d5139
1 parent 50d4f43
commit 92d5139
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -7,8 +7,6 @@ on:
       - "gh-pages/*"
       - "main"
       - "master"
-  pull_request:
-    types: [opened, reopened]
   schedule:
     # “At 00:00 on every 7th day-of-month from 1 through 31.” (https://crontab.guru)
     - cron: "0 0 1/7 * *"

diff --git a/doc/changes/unreleased.md b/doc/changes/unreleased.md
@@ -1 +1,7 @@
 # Unreleased
+
+## 🐞 Fixed
+* Fixed an issue in the CI workflow that caused it to be executed twice on the initial push of a PR if the PR branch was on the repo itself.
+
+    🚨 Attention: Due to these changes, the workflows will no longer be executed if the PR comes from a branch not located in this repository.
+                  As third-party contributions from outside forks are rare to nearly non-existent, this downside was considered a reasonable trade-off at this time.
diff --git a/exasol/toolbox/templates/github/workflows/ci.yml b/exasol/toolbox/templates/github/workflows/ci.yml
@@ -7,8 +7,6 @@ on:
       - "gh-pages/*"
       - "main"
       - "master"
-  pull_request:
-    types: [opened, reopened]
   schedule:
     # “At 00:00 on every 7th day-of-month from 1 through 31.” (https://crontab.guru)
     - cron: "0 0 1/7 * *"