Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#44 Features from pytest-itde and pytest-saas migrated to pytest-backend #45

Merged
merged 5 commits into from
Aug 14, 2024
Merged

#44 Features from pytest-itde and pytest-saas migrated to pytest-backend #45

merged 5 commits into from
Aug 14, 2024

Conversation

ahsimb
Copy link
Contributor

@ahsimb ahsimb commented Aug 13, 2024

closes #44

@ahsimb ahsimb added the refactoring Code improvement without behavior change label Aug 13, 2024
@ahsimb ahsimb self-assigned this Aug 13, 2024
Nicoretti
Nicoretti previously approved these changes Aug 14, 2024
View reviewed changes
pytest-backend/exasol/pytest_backend/itde.py
import pytest

from exasol_integration_test_docker_environment.lib.test_environment.ports import Ports
import exasol.pytest_backend.config as config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import exasol.pytest_backend.config as config
from exasol.pytest_backend import config

Should do the same for you

pytest-backend/test/unit/test_itde_backend.py
ItdeOption,
ItdeOptionGroup,
)
import exasol.pytest_backend.config as config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import exasol.pytest_backend.config as config
from exasol.pytest_backend import config

@ahsimb ahsimb merged commit c136825 into main Aug 14, 2024
1 check passed
@ahsimb ahsimb deleted the refactoring/44-make-backend-independent branch August 14, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicoretti Nicoretti Nicoretti approved these changes

Assignees

@ahsimb ahsimb

Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Divorce pytest-backend from pytest-itde and pytest-saas
2 participants
@ahsimb @Nicoretti