Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18: Implemented keep alive for saas-database #20

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented May 29, 2024

closes #18
Closes #19


## Bugfixes

* #19: Fixed removing ip whitelist rule at the end of the test session
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR fixes both issues (#18 and #19), add the comment in the PR

Copy link
Contributor Author

@ckunki ckunki Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important finding.
I added "closes" comment to PR
Please approve again

@ckunki ckunki requested a review from tomuben June 3, 2024 07:32
@ckunki ckunki merged commit d727175 into main Jun 3, 2024
1 check passed
@ckunki ckunki deleted the feature/#18-Implemented_keep_alive_for_saas-database branch June 3, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip whitelist rule is not cleaned up after running a test case Implement keep alive for saas-database
2 participants