#556: Create tags for Go projects #560
Conversation
There was a problem hiding this comment.
Please forgive my finding / proposal: At some day we might need to think of a way to verify workflow files in tests. Either we create a parser and runner on our own or maybe someone else had the same challenge before .... 🤔
There was a problem hiding this comment.
Good point. One option could be to extract the shell scripts and simply run them in integration tests. @redcatbear suggested to skip for now. If we modify the workflow/scripts more often, we can think about adding these tests.
| echo "release-url=$release_url" >> "$GITHUB_OUTPUT" | ||
|
|
||
| echo "#### Creating Additional Tags" >> "$GITHUB_STEP_SUMMARY" |
There was a problem hiding this comment.
Maybe a comment or a reference to requirements / design would be nice, here?
E.g.
# Go projects need an additional tag prefixed with "v"- or
[impl->dsn~release-workflow.create-golang-tags~1]
There was a problem hiding this comment.
Oh, I see an additional challenge - maybe 2 challenges:
- file might be generated by PK so the reqs might apply to the template file but should not affect req tracing of a project using PK to generate its workflow files. 🤔 Oh oh ....
- maybe file is even modified as PK itself has deviates from default?
There was a problem hiding this comment.
The req tracing tag is added to project-keeper/src/main/resources/templates/.github/workflows/release.yml:
# [impl->dsn~release-workflow.create-golang-tags~1]
echo "#### Creating Additional Tags" >> "$GITHUB_STEP_SUMMARY"
...Regarding your second comment:
- Workflow files should not affect req tracing in other projects, because usually the
.githubfolder is not scanned for requirements - Yes, the file was modified for PK itself. This will be fixed once we can customize the build steps.
project-keeper/src/main/java/com/exasol/projectkeeper/github/GitHubWorkflowOutput.java
Show resolved
Hide resolved
project-keeper/src/main/java/com/exasol/projectkeeper/sources/AnalyzedSourceImpl.java
Show resolved
Hide resolved
project-keeper/src/main/resources/templates/.github/workflows/ci-build-db-version-matrix.yml
Outdated
Show resolved
Hide resolved
...t-keeper/src/test/java/com/exasol/projectkeeper/sources/analyze/generic/SimpleProcessIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Christoph Kuhnke <[email protected]>
|
...t-keeper/src/test/java/com/exasol/projectkeeper/sources/analyze/generic/SimpleProcessIT.java
Show resolved
Hide resolved
Closes #556