#515: Refactor starting a maven process: use MavenProcessBuilder #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaklakariada
changed the title
ckunki
requested changes
Feb 8, 2024
maven-project-crawler/src/main/java/com/exasol/projectkeeper/MavenProjectCrawlerMojo.java
Outdated
Show resolved
Hide resolved
...n/src/test/java/com/exasol/projectkeeper/plugin/MvnProjectWithProjectKeeperPluginWriter.java
Show resolved
Hide resolved
|
|
||
| LOGGER.fine(() -> "Executing command " + commandParts); | ||
| final Process proc = new ProcessBuilder(commandParts).redirectErrorStream(true).start(); | ||
| final MavenProcessBuilder builder = buildMavenCommand(pomFiles); |
There was a problem hiding this comment.
In this place I would enjoy a short explanation:
- Why does model cache no longer need to be diabled?
There was a problem hiding this comment.
In general the new implementation seems to be much more elegant.
There was a problem hiding this comment.
The code for overriding the model cache is moved to another method
...eper/src/main/java/com/exasol/projectkeeper/sources/analyze/generic/MavenProcessBuilder.java
Outdated
Show resolved
Hide resolved
...eper/src/main/java/com/exasol/projectkeeper/validators/files/LatestChangesFileValidator.java
Show resolved
Hide resolved
Co-authored-by: Christoph Kuhnke <[email protected]>
|
ckunki
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #515