#108: Allowed configuration on javadoc plugin (#146)

* #108: Allowed configuration on javadoc plugin
exasol · Jun 22, 2021 · 98972c8 · 98972c8
1 parent 3a06d85
commit 98972c8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/doc/changes/changes_0.8.0.md b/doc/changes/changes_0.8.0.md
@@ -1,18 +1,23 @@
-# Project keeper maven plugin 0.8.0, released 2021-??-??
+# Project keeper maven plugin 0.8.0, released 2021-06-22
 
-Code name:
+Code name: Added Jar Plugin
 
-## Features:
+## Summary
+
+In this release we added a configuration for the maven-jar-plugin to disable the default (non-fat) jar on jar_artifact builds. In addition, we added a requirement specification and design and fixed some bugs.
+
+## Features
 
 * #127: Added maven-jar-plugin configuration for disabling default (non-fat) jar on jar_artifact builds
 
 ## Documentation
 
 * #20: Added requirements and design
 
-## Bug Fixes:
+## Bug Fixes
 
 * #144 Fixed that whitespace in linkReplacement was not stripped
+* #108: Allowed configuration on javadoc plugin
 
 ## Dependency Updates
 

diff --git a/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java b/src/main/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidator.java
@@ -29,6 +29,10 @@ public ProjectKeeperModule getModule() {
     protected void validatePluginConfiguration(final Node plugin, final Collection<ProjectKeeperModule> enabledModules,
             final Consumer<ValidationFinding> findingConsumer) {
         verifyPluginPropertyHasExactValue(plugin, "executions", findingConsumer);
-        verifyPluginPropertyHasExactValue(plugin, "configuration", findingConsumer);
+        verifyPluginPropertyHasExactValue(plugin, "configuration/charset", findingConsumer);
+        verifyPluginPropertyHasExactValue(plugin, "configuration/doclint", findingConsumer);
+        verifyPluginPropertyHasExactValue(plugin, "configuration/serialwarn", findingConsumer);
+        verifyPluginPropertyHasExactValue(plugin, "configuration/failOnError", findingConsumer);
+        verifyPluginPropertyHasExactValue(plugin, "configuration/failOnWarnings", findingConsumer);
     }
 }
diff --git a/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java b/src/test/java/com/exasol/projectkeeper/validators/pom/plugin/JavadocPluginValidatorTest.java
@@ -20,7 +20,7 @@ class JavadocPluginValidatorTest extends AbstractMavenPluginPomValidatorTest {
         super(new JavadocPluginValidator());
     }
 
-    @ValueSource(strings = { "executions", "executions/execution", "configuration" })
+    @ValueSource(strings = { "executions", "executions/execution", "configuration", "configuration/serialwarn" })
     @ParameterizedTest
     void testMissingExecutions(final String removeXpath)
             throws ParserConfigurationException, SAXException, IOException {