Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119: Fix joining HASHTYPE columns #118

Merged
merged 31 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
e25b6eb
Add test to reproduce error
kaklakariada Feb 7, 2024
1acdf7f
Add integration test for HASHTYPE join
kaklakariada Feb 8, 2024
4392c87
Update EXA query rewriter to specify column types
kaklakariada Feb 8, 2024
ae7f407
Fix typo
kaklakariada Feb 8, 2024
dbb3d9e
Remove overridden tests
kaklakariada Feb 8, 2024
d3b70fa
Use EXA connection in pushdown query
kaklakariada Feb 8, 2024
4afb2a5
Increment version
kaklakariada Feb 8, 2024
a8fb294
Fix cleanup after test
kaklakariada Feb 8, 2024
6d8fa4f
Update references
kaklakariada Feb 8, 2024
16a5e63
Mark file as generated
kaklakariada Feb 8, 2024
8075d77
Add unit tests for query rewriters
kaklakariada Feb 8, 2024
b0bf95c
Added changelog entry
kaklakariada Feb 8, 2024
15ddfdc
Reduce visibility of rewriters
kaklakariada Feb 8, 2024
6c7fa50
Fix comment
kaklakariada Feb 8, 2024
3d7622a
Fix compiler warnings
kaklakariada Feb 8, 2024
dcaedc2
Update release date
kaklakariada Feb 9, 2024
9833fdb
Update configuration for vscode
kaklakariada Feb 9, 2024
c9b95e8
Increment major version number
kaklakariada Feb 9, 2024
3af393b
Increment minor version
kaklakariada Feb 21, 2024
4c10f92
Remove unused file
kaklakariada Feb 21, 2024
8dd6672
Fix vulnerability in dependency
kaklakariada Feb 21, 2024
67a6bba
Add user guide entry
kaklakariada Feb 21, 2024
309cd02
Add property
kaklakariada Feb 21, 2024
9c997d0
Implement feature switch for data type converter
kaklakariada Feb 21, 2024
508bf0f
Upgrade Exasol DB version
kaklakariada Feb 21, 2024
89841c3
Upgrade testcontainers
kaklakariada Feb 22, 2024
51ffe00
Fix integration tests
kaklakariada Feb 22, 2024
0db7f41
Revert upgrade of vscjdbc
kaklakariada Feb 22, 2024
3c3e00c
Update changelog entry
kaklakariada Feb 22, 2024
2e86c0b
Improve test coverage
kaklakariada Feb 22, 2024
531c6f1
Implement review findings
kaklakariada Feb 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ pk_generated_parent.pom linguist-genera
.github/workflows/release_droid_prepare_original_checksum.yml linguist-generated=true
.github/workflows/release_droid_print_quick_checksum.yml linguist-generated=true
.github/workflows/release_droid_release_on_maven_central.yml linguist-generated=true
.github/workflows/release_droid_upload_github_release_assets.yml linguist-generated=true
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
.settings/org.eclipse.jdt.ui.prefs linguist-generated=true

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/broken_links_checker.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions .github/workflows/ci-build-next-java.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 13 additions & 9 deletions .github/workflows/ci-build.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions .github/workflows/dependencies_check.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions .github/workflows/release_droid_prepare_original_checksum.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions .github/workflows/release_droid_print_quick_checksum.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions .github/workflows/release_droid_release_on_maven_central.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 7 additions & 4 deletions .github/workflows/release_droid_upload_github_release_assets.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.organizeImports": true,
"source.generate.finalModifiers": true,
"source.fixAll": true
"source.organizeImports": "explicit",
"source.generate.finalModifiers": "explicit",
"source.fixAll": "explicit"
},
"java.codeGeneration.useBlocks": true,
"java.saveActions.organizeImports": true,
Expand Down
96 changes: 49 additions & 47 deletions dependencies.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions doc/changes/changelog.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions doc/changes/changes_7.1.7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Exasol Virtual Schema 7.1.7, released 2024-02-09

Code name: Fix data types for `IMPORT FROM EXA`

## Summary

This release fixes the data types reported for virtual schemas using `IMPORT FROM EXA`. The Exasol specific types `GEOMETRY`, `INTERVAL YEAR TO MONTH`, `INTERVAL DAY TO SECOND` and `HASHTYPE` were mapped to `VARCHAR` before. The virtual schema now returns these types correctly.

This also fixes a bug when joining a table in a virtual schema with a normal table using a `HASHTYPE` column. This failed before in Exasol 7.1 with error message `Feature not supported: Incomparable Types: VARCHAR(32) UTF8 and HASHTYPE(16 BYTE)!`. In Exasol 8 the error message was `Adapter generated invalid pushdown query for virtual table VIRTUAL: Data type mismatch in column number 1 (1-indexed).Expected HASHTYPE(16 BYTE), but got VARCHAR(32) UTF8.`.

## Bugfixes

* #119: Fixed data types for `IMPORT FROM EXA`

## Dependency Updates

### Test Dependency Updates

* Updated `com.exasol:test-db-builder-java:3.5.2` to `3.5.3`

### Plugin Dependency Updates

* Updated `com.exasol:project-keeper-maven-plugin:2.9.16` to `3.0.1`
* Updated `org.apache.maven.plugins:maven-failsafe-plugin:3.2.2` to `3.2.3`
* Updated `org.apache.maven.plugins:maven-surefire-plugin:3.2.2` to `3.2.3`
* Added `org.apache.maven.plugins:maven-toolchains-plugin:3.1.0`
* Updated `org.codehaus.mojo:versions-maven-plugin:2.16.1` to `2.16.2`
2 changes: 1 addition & 1 deletion doc/dialects/exasol.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The SQL statement below creates the adapter script, defines the Java class that
```sql
CREATE JAVA ADAPTER SCRIPT SCHEMA_FOR_VS_SCRIPT.ADAPTER_SCRIPT_EXASOL AS
%scriptclass com.exasol.adapter.RequestDispatcher;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-11.0.2-exasol-7.1.6.jar;
%jar /buckets/<BFS service>/<bucket>/virtual-schema-dist-11.0.2-exasol-7.1.7.jar;
/
```

Expand Down
Loading
Loading