Apply suggestions from code review

Co-authored-by: Christoph Pirkl <[email protected]>
exasol · Apr 2, 2024 · d25af86 · d25af86
1 parent 6fc7f56
commit d25af86
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/doc/changes/changes_8.0.0.md b/doc/changes/changes_8.0.0.md
@@ -1,6 +1,6 @@
 # Exasol Virtual Schema 8.0.0, released 2024-04-02
 
-Code name: Charset is always `utf-8`, deprecated IMPORT_DATA_TYPES `FROM_RESULT_SET` value .
+Code name: Charset is always `utf-8`, deprecated IMPORT_DATA_TYPES `FROM_RESULT_SET` value
 
 ## Summary
 

diff --git a/doc/dialects/exasol.md b/doc/dialects/exasol.md
@@ -113,6 +113,7 @@ Pushdown query with `GENERATE_JDBC_DATATYPE_MAPPING_FOR_EXA = 'true'`:
 ```sql
 IMPORT INTO (c1 DECIMAL(36,1), c2 .... ) FROM EXA AT "EXA_CONNECTION" STATEMENT '...'
 ```
+
 ##### Data type mismatch
 
 In case you run into a `Data type mismatch` issue when using EXA import turning this property on will usually also solve the issue by providing type hints.

diff --git a/pom.xml b/pom.xml
@@ -167,7 +167,6 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-javadoc-plugin</artifactId>
-                <version>3.6.3</version>
                 <configuration>
                     <failOnError>true</failOnError>
                     <additionalOptions>

diff --git a/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java b/src/test/java/com/exasol/adapter/dialects/exasol/ExasolSqlDialectExaConnectionIT.java
@@ -78,7 +78,7 @@ protected Map<String, String> getConnectionSpecificVirtualSchemaProperties() {
     //
     // The tests using the newer GENERATE_JDBC_DATATYPE_MAPPING_FOR_EXA switch that fixes most of the issues with strict
     // datatype checking on the pushed down queries
-    // can be found in ExasolSqlDialectExaConnectionWithDataTypesIT .
+    // can be found in ExasolSqlDialectExaConnectionWithDataTypesIT.
 
     @Test
     void testPasswordNotVisibleInImportFromExa() throws NoDriverFoundException, SQLException {
-Original file line number
+Diff line change
@@ Expand Up @@
     ```sql
     IMPORT INTO (c1 DECIMAL(36,1), c2 .... ) FROM EXA AT "EXA_CONNECTION" STATEMENT '...'
     ```
     ##### Data type mismatch
     In case you run into a `Data type mismatch` issue when using EXA import turning this property on will usually also solve the issue by providing type hints.
@@ Expand Down @@