Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#108: Convert args for prepared statements to expected type #112

Merged
merged 10 commits into from
Jun 19, 2024
Merged

#108: Convert args for prepared statements to expected type #112

merged 10 commits into from
Jun 19, 2024

Conversation

kaklakariada
Copy link
Collaborator

Closes #108

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

pj-spoelders
pj-spoelders requested changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@pj-spoelders pj-spoelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as always, but you'll need to address the quality gate's comments.

pj-spoelders
pj-spoelders approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@pj-spoelders pj-spoelders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, approved!

@kaklakariada kaklakariada merged commit 22ad9c3 into main Jun 19, 2024
7 of 8 checks passed
@kaklakariada kaklakariada deleted the kaklakariada/issue108 branch June 19, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pj-spoelders pj-spoelders pj-spoelders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E-EGOD-11: execution failed with SQL error code '00000' and message 'getDouble: JSON value is not a double
2 participants
@kaklakariada @pj-spoelders