Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access to public S3 buckets without credentials #287

Merged
merged 10 commits into from
Nov 10, 2023
Merged

Access to public S3 buckets without credentials #287

merged 10 commits into from
Nov 10, 2023

Conversation

Shmuma
Copy link
Collaborator

@Shmuma Shmuma commented Nov 8, 2023 •
edited
Loading

Closes #283

  • basic implementation of the functionality
  • unit tests
  • document the new mode for public buckets
  • release

@Shmuma Shmuma marked this pull request as ready for review November 9, 2023 13:43
kaklakariada
kaklakariada requested changes Nov 10, 2023
View reviewed changes
src/test/scala/com/exasol/cloudetl/bucket/S3BucketTest.scala Outdated Show resolved Hide resolved
doc/user_guide/user_guide.md Outdated Show resolved Hide resolved
Shmuma and others added 2 commits November 10, 2023 08:45
@Shmuma @kaklakariada
Typo
aa1a3c7 
Co-authored-by: Christoph Pirkl <[email protected]>
@Shmuma @kaklakariada
Update doc/user_guide/user_guide.md
6e628ed 
Co-authored-by: Christoph Pirkl <[email protected]>
@Shmuma Shmuma enabled auto-merge (squash) November 10, 2023 07:48
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.9% 90.9% Coverage
0.0% 0.0% Duplication

@Shmuma Shmuma merged commit 5c222f9 into main Nov 10, 2023
9 checks passed
@Shmuma Shmuma deleted the feature/283_public_s3_ branch November 10, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaklakariada kaklakariada kaklakariada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support publicly available S3 buckets without credentials required
2 participants
@Shmuma @kaklakariada