Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#170 Moved to pytest-exasol-backend #171

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Conversation

ahsimb
Copy link

@ahsimb ahsimb commented Nov 20, 2024

closes #170

Submission Checklist

  • Updated the changelog in file doc/changes/unreleasd.md

If required

  • Updated Documentation
  • Updated API Documentation

If doing a release

  • Bumped version number using poetry run nox -s prepare-release

@ahsimb ahsimb added the refactoring Code improvement without behavior change label Nov 20, 2024
@ahsimb ahsimb self-assigned this Nov 20, 2024
Copy link
Collaborator

@MarleneKress79789 MarleneKress79789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see anything wrong

- name: Install Project
run: poetry install

- name: Checkout ITDE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not need the ITDE anymore? or is it handeled by the pytest-exasol backend?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see configuration in the pytest-exasol backend, but no place the ITDE is actually installed. can you point me to it? i am probably not looking in the right place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not start the ITDE manually when using the pytest plugins. the pytest-exasol-backend does it for us.

@ahsimb ahsimb merged commit 7b16d26 into main Nov 25, 2024
14 checks passed
@ahsimb ahsimb deleted the refactoring/170-pytest-backend branch November 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move from pytest-exasol-saas to pytest-exasol-backend
2 participants