Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#113 Added implementation for the SaaS Bucket. #116

Merged
merged 16 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ jobs:
- name: Install Project
run: poetry install

- name: Run SaaS Tests
env:
SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }}
SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }}
SAAS_PAT: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_PAT }}
run: poetry run pytest test_saas

- name: Checkout ITDE
run: git clone https://github.com/exasol/integration-test-docker-environment.git
working-directory: ..
Expand All @@ -49,3 +56,4 @@ jobs:

- name: Run Tests
run: poetry run pytest tests

1 change: 1 addition & 0 deletions doc/changes/unreleased.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
Extracted bucket interface into BucketLike protocol.
Implemented PathLike for buckets based on BucketLike protocol.
Added a path factory function.
Added implementation of the BucketLike for the SaaS BucketFS.

- `verify` parameter to the old interface.

Expand Down
4 changes: 4 additions & 0 deletions exasol/bucketfs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@
from exasol.bucketfs._buckets import (
BucketLike,
Bucket,
SaaSBucket,
MountedBucket,
MappedBucket,
)
from exasol.bucketfs._convert import (
Expand All @@ -64,6 +66,8 @@
"Service",
"BucketLike",
"Bucket",
"SaaSBucket",
"MountedBucket",
"MappedBucket",
"BucketFsError",
"path",
Expand Down
100 changes: 86 additions & 14 deletions exasol/bucketfs/_buckets.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,14 @@
import requests
from requests import HTTPError
from requests.auth import HTTPBasicAuth
from urllib.parse import quote_plus

from exasol.saas.client.openapi.client import AuthenticatedClient as SaasAuthenticatedClient
from exasol.saas.client.openapi.models.file import File as SaasFile
from exasol.saas.client.openapi.api.files.list_files import sync as saas_list_files
from exasol.saas.client.openapi.api.files.delete_file import sync_detailed as saas_delete_file
from exasol.saas.client.openapi.api.files.upload_file import sync_detailed as saas_upload_file
from exasol.saas.client.openapi.api.files.download_file import sync_detailed as saas_download_file

from exasol.bucketfs._error import BucketFsError
from exasol.bucketfs._logging import LOGGER
Expand Down Expand Up @@ -177,7 +185,7 @@ def _auth(self) -> HTTPBasicAuth:
@property
def files(self) -> Iterable[str]:
url = _build_url(service_url=self._service, bucket=self.name)
LOGGER.info(f"Retrieving bucket listing for {self.name}.")
LOGGER.info("Retrieving bucket listing for %s.", self.name)
response = requests.get(url, auth=self._auth, verify=self._verify)
try:
response.raise_for_status()
Expand All @@ -201,7 +209,7 @@ def upload(
data: raw content of the file.
"""
url = _build_url(service_url=self._service, bucket=self.name, path=path)
LOGGER.info(f"Uploading {path} to bucket {self.name}.")
LOGGER.info("Uploading %s to bucket %s.", path, self.name)
response = requests.put(url, data=data, auth=self._auth, verify=self._verify)
try:
response.raise_for_status()
Expand All @@ -219,8 +227,9 @@ def delete(self, path) -> None:
A BucketFsError if the operation couldn't be executed successfully.
"""
url = _build_url(service_url=self._service, bucket=self.name, path=path)
LOGGER.info(f"Deleting {path} from bucket {self.name}.")
LOGGER.info("Deleting %s from bucket %s.", path, self.name)
response = requests.delete(url, auth=self._auth, verify=self._verify)

try:
response.raise_for_status()
except HTTPError as ex:
Expand All @@ -239,7 +248,8 @@ def download(self, path: str, chunk_size: int = 8192) -> Iterable[ByteString]:
"""
url = _build_url(service_url=self._service, bucket=self.name, path=path)
LOGGER.info(
f"Downloading {path} using a chunk size of {chunk_size} bytes from bucket {self.name}."
"Downloading %s using a chunk size of %d bytes from bucket %s.",
path, chunk_size, self.name
)
with requests.get(
url, stream=True, auth=self._auth, verify=self._verify
Expand All @@ -257,7 +267,7 @@ class SaaSBucket:
def __init__(self, url: str, account_id: str, database_id: str, pat: str) -> None:
self._url = url
self._account_id = account_id
self.database_id = database_id
self._database_id = database_id
self._pat = pat

@property
Expand All @@ -268,24 +278,86 @@ def name(self) -> str:
def udf_path(self) -> str:
return f'/buckets/uploads/{self.name}'

@property
def files(self) -> Iterable[str]:
"""To be provided"""
raise NotImplementedError()
LOGGER.info("Retrieving the bucket listing.")
with SaasAuthenticatedClient(base_url=self._url,
token=self._pat,
raise_on_unexpected_status=True) as client:
content = saas_list_files(account_id=self._account_id,
database_id=self._database_id,
client=client)

file_list: list[str] = []

def recursive_file_collector(node: SaasFile) -> None:
if node.children:
for child in node.children:
recursive_file_collector(child)
else:
file_list.append(node.path)

for root_node in content:
recursive_file_collector(root_node)

return file_list

def delete(self, path: str) -> None:
"""To be provided"""
raise NotImplementedError()
LOGGER.info("Deleting %s from the bucket.", path)
with SaasAuthenticatedClient(base_url=self._url,
token=self._pat,
raise_on_unexpected_status=True) as client:
saas_delete_file(account_id=self._account_id,
database_id=self._database_id,
key=quote_plus(path),
client=client)

def upload(self, path: str, data: ByteString | BinaryIO) -> None:
"""To be provided"""
raise NotImplementedError()
LOGGER.info("Uploading %s to the bucket.", path)
# Q. The service can handle any characters in the path.
# Do we need to check this path for presence of characters deemed
# invalid in the BucketLike protocol?
with SaasAuthenticatedClient(base_url=self._url,
token=self._pat,
raise_on_unexpected_status=False) as client:
response = saas_upload_file(account_id=self._account_id,
database_id=self._database_id,
key=quote_plus(path),
client=client)
if response.status_code >= 400:
# Q. Is it the right type of exception?
raise RuntimeError(f'Request for a presigned url to upload the file {path} '
f'failed with the status code {response.status_code}')
upload_url = response.parsed.url.replace(r'\u0026', '&')

response = requests.put(upload_url, data=data)
response.raise_for_status()

def download(self, path: str, chunk_size: int = 8192) -> Iterable[ByteString]:
"""To be provided"""
raise NotImplementedError()
LOGGER.info("Downloading %s from the bucket.", path)
with SaasAuthenticatedClient(base_url=self._url,
token=self._pat,
raise_on_unexpected_status=False) as client:
response = saas_download_file(account_id=self._account_id,
database_id=self._database_id,
key=quote_plus(path),
client=client)
if response.status_code == 404:
raise BucketFsError("The file {path} doesn't exist in the SaaS BucketFs.")
elif response.status_code >= 400:
# Q. Is it the right type of exception?
raise RuntimeError(f'Request for a presigned url to download the file {path} '
f'failed with the status code {response.status_code}')
download_url = response.parsed.url.replace(r'\u0026', '&')

response = requests.get(download_url, stream=True)
response.raise_for_status()
for chunk in response.iter_content(chunk_size=chunk_size):
if chunk:
yield chunk

def __str__(self):
return f"SaaSBucket<{self.name} | on: {self._url}>"
return f"SaaSBucket<account id: {self._account_id}, database id: {self._database_id}>"


class MountedBucket:
Expand Down
Loading
Loading