Supported pushing Docker image to a Docker registry #89
Conversation
| _logger.setLevel(logging.DEBUG) | ||
|
|
||
|
|
||
| class LocalDockerRegistry(DockerRegistry): |
There was a problem hiding this comment.
Compared to ITDE I did not need a LocalDockerRegistryContextManager as the pytest fixture already provides context-like functionality.
The reason for the earlier construct returning a context was the parameter repository to the registry which now has become obsolete and has been removed.
Added test to verify DssDockerImage calls registry.push()
I added tests with |
| registry: LocalDockerRegistry, | ||
| tag: str = None, | ||
| ): | ||
| def tagged_image(old: DockerImageSpec, new: DockerImageSpec): | ||
| """ | ||
| Prepend host and port of LocalDockerRegistry to the repository name of the |
There was a problem hiding this comment.
this description is outdated
There was a problem hiding this comment.
Ouch - you're right. Will be fixed in next push.
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def docker_registry(request): | ||
| def docker_registry(request, registry_image): | ||
| """ | ||
| Provide a context for creating a LocalDockerRegistry accepting | ||
| parameter ``repository``. |
There was a problem hiding this comment.
this description seems to be also a little bit outdated
There was a problem hiding this comment.
Yes, correct, thanks!
See next push.
| with tagged_image(dss_docker_image, docker_registry) as tagged: | ||
| tagged._push() | ||
| def test_push_tag(sample_docker_image, docker_registry): | ||
| old = DockerImageSpec("registry", "2") |
There was a problem hiding this comment.
I think, you don't need this, because you are getting samle_docker_image as input
There was a problem hiding this comment.
Yes, see next push for a simplified version.
test/unit/test_dss_docker_image.py
Outdated
| registry = DockerRegistry("user", "password") | ||
| registry.push = MagicMock() |
There was a problem hiding this comment.
you can use registry = create_autospec(DockerRegistry), don't use workarounds everywhere only because you used it once.
There was a problem hiding this comment.
Very good. Thanks. See next push.
Closes #36