Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated nb-connector for pinned slc_release #329

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Updated nb-connector for pinned slc_release #329

merged 4 commits into from
Sep 6, 2024

Conversation

tomuben
Copy link
Contributor

@tomuben tomuben commented Sep 6, 2024

@tomuben tomuben had a problem deploying to approve-test-execution September 6, 2024 09:04 — with GitHub Actions Failure
tkilias
tkilias previously approved these changes Sep 6, 2024
View reviewed changes
@tomuben tomuben temporarily deployed to approve-test-execution September 6, 2024 09:23 — with GitHub Actions Inactive
@tomuben tomuben temporarily deployed to approve-test-execution September 6, 2024 10:36 — with GitHub Actions Inactive
tkilias
tkilias reviewed Sep 6, 2024
View reviewed changes
test/notebooks/nbtest_script_languages_container.py
@@ -17,13 +18,14 @@ def _slc_repo_dir() -> Path:
return Path.cwd() / "script_languages_release"


def _store_slc_config(store_path: Path, store_password: str, clone_repo: bool):
def _store_slc_config(store_path: Path, store_password: str, clone_repo: bool) -> Secrets:

slc_source = "Clone script languages release repository" if clone_repo else "Use the existing clone"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions, but that we can discus later

@tomuben tomuben temporarily deployed to approve-test-execution September 6, 2024 12:07 — with GitHub Actions Inactive
@tomuben tomuben enabled auto-merge (squash) September 6, 2024 12:57
@tomuben tomuben merged commit 37fc7e2 into main Sep 6, 2024
14 of 15 checks passed
@tomuben tomuben deleted the refactoring/update_nb_connector_for_pinned_slc_release branch September 6, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomuben @tkilias