Refactoring/#258 used a non root user to run jupyter in the docker image ai lab #231

ckunki · 2024-02-26T10:03:48Z

Closes #66

Additionally Same as AMI and VM Editions also the Docker Edition uses a non-root user for executing the ansible installation.

added dependency to gpg-agent

fixed Ansible warning about providing a list of dictionaries to vars: See https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_8.html#deprecated

…_Jupyter_in_the_Docker_Image_ai-lab

ckunki · 2024-02-27T13:43:54Z

exasol/ds/sandbox/lib/dss_docker/create_image.py

+        try:
+            return docker_client.containers.get(self.container_name)
+        except:
+            pass


I added these lines to speed up testing Ansible tasks

exasol/ds/sandbox/runtime/ansible/general_setup_tasks.yml

exasol/ds/sandbox/runtime/ansible/roles/jupyter/tasks/pip-install.yml

exasol/ds/sandbox/runtime/ansible/general_setup_tasks.yml

exasol/ds/sandbox/runtime/ansible/roles/jupyter/tasks/pip-install.yml

As integration tests in test_create_dss_docker_image.py failed with timeout error in test_install_notebook_connector during docker.commit().

[run-notebook-tests]

[CodeBuild]

…_Jupyter_in_the_Docker_Image_ai-lab

doc/user_guide/ami-usage.md

doc/user_guide/docker/docker-usage.md

test/codebuild/test_ci.py

test/integration/test_create_dss_docker_image.py

test/integration/test_motd_jupyter_template.py

exasol/ds/sandbox/runtime/ansible/roles/jupyter/templates/etc/update-motd.d/999-jupyter

…update-motd.d/999-jupyter Co-authored-by: Torsten Kilias <[email protected]>

…_Jupyter_in_the_Docker_Image_ai-lab

ckunki added 3 commits February 23, 2024 13:56

Use separate user for running Jupyter

7bacff9

Used a non-root user to run Jupyter in the Docker Image ai-lab

6663562

Additionally Same as AMI and VM Editions also the Docker Edition uses a non-root user for executing the ansible installation.

Additional changes based on experiments

194e9d1

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 08:48 — with GitHub Actions Failure

ckunki added 2 commits February 27, 2024 11:27

Fixed ansible tasks

5befe3e

added dependency to gpg-agent

remove commented line

1e510fc

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 10:28 — with GitHub Actions Failure

ckunki added 2 commits February 27, 2024 12:20

Added become for disabling core dumps

69de9d8

poetry lock

d9eed17

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 11:21 — with GitHub Actions Failure

Fixed test

af1a929

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 12:42 — with GitHub Actions Failure

ckunki added 2 commits February 27, 2024 14:09

Improved Ansible output for pip install

c776849

fixed Ansible warning about providing a list of dictionaries to vars: See https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_8.html#deprecated

Improved Ansible output for pip install

36117ea

fixed Ansible warning about providing a list of dictionaries to vars: See https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_8.html#deprecated

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 13:25 — with GitHub Actions Failure

Merge branch 'main' into refactoring/#258-Used_a_non-root_user_to_run…

5229b26

…_Jupyter_in_the_Docker_Image_ai-lab

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 13:33 — with GitHub Actions Failure

Removed test scaffolds

2304741

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 13:45 — with GitHub Actions Failure

Capitalized name of Ansible task

b030baf

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 13:47 — with GitHub Actions Failure

Updated comments in Ansible tasks

a66235d

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 13:50 — with GitHub Actions Failure

ckunki commented Feb 27, 2024

View reviewed changes

tkilias requested changes Feb 27, 2024

View reviewed changes

exasol/ds/sandbox/runtime/ansible/general_setup_tasks.yml Outdated Show resolved Hide resolved

exasol/ds/sandbox/runtime/ansible/roles/jupyter/tasks/pip-install.yml Outdated Show resolved Hide resolved

ckunki added 4 commits February 27, 2024 17:33

Updated user guide for Docker Edition

71ecf25

Updated tests for docker Edition

514cdd0

Increased time out for commiting the Docker container

50b4432

As integration tests in test_create_dss_docker_image.py failed with timeout error in test_install_notebook_connector during docker.commit().

Added comment for timeout

b595ae6

ckunki had a problem deploying to AWS_CI_TESTS February 27, 2024 16:39 — with GitHub Actions Failure

ckunki temporarily deployed to AWS_CI_TESTS February 28, 2024 11:47 — with GitHub Actions Inactive

Updated dependency network-manager

7ee7abf

[run-notebook-tests]

ckunki temporarily deployed to AWS_CI_TESTS February 28, 2024 12:10 — with GitHub Actions Inactive

ckunki had a problem deploying to AWS_SAGEMAKER February 28, 2024 12:10 — with GitHub Actions Failure

[CodeBuild]

887d558

ckunki temporarily deployed to AWS_CI_TESTS February 28, 2024 12:14 — with GitHub Actions Inactive

Fixed test test_jupyter_password_message_shown

8ace780

[CodeBuild]

ckunki temporarily deployed to AWS_CI_TESTS February 28, 2024 13:05 — with GitHub Actions Inactive

ckunki added 2 commits February 28, 2024 14:42

Removed comment

427696b

Merge branch 'main' into refactoring/#258-Used_a_non-root_user_to_run…

3467495

…_Jupyter_in_the_Docker_Image_ai-lab

ckunki temporarily deployed to AWS_CI_TESTS February 28, 2024 13:43 — with GitHub Actions Inactive

tkilias requested changes Feb 28, 2024

View reviewed changes

ckunki added 2 commits February 28, 2024 15:41

Fixed review findings

524656a

Fixed review findings

dfb6b5e

ckunki had a problem deploying to AWS_CI_TESTS February 28, 2024 15:03 — with GitHub Actions Failure

tkilias reviewed Feb 29, 2024

View reviewed changes

exasol/ds/sandbox/runtime/ansible/roles/jupyter/templates/etc/update-motd.d/999-jupyter Outdated Show resolved Hide resolved

Update exasol/ds/sandbox/runtime/ansible/roles/jupyter/templates/etc/…

0574c95

…update-motd.d/999-jupyter Co-authored-by: Torsten Kilias <[email protected]>

ckunki had a problem deploying to AWS_CI_TESTS February 29, 2024 10:01 — with GitHub Actions Failure

Fixed review finding

1778e81

ckunki had a problem deploying to AWS_CI_TESTS February 29, 2024 10:03 — with GitHub Actions Failure

ckunki requested a review from tkilias February 29, 2024 10:03

tkilias previously approved these changes Feb 29, 2024

View reviewed changes

Fixed failing test

b10fa2e

ckunki dismissed tkilias’s stale review via b10fa2e February 29, 2024 10:19

ckunki temporarily deployed to AWS_CI_TESTS February 29, 2024 10:19 — with GitHub Actions Inactive

Merge branch 'main' into refactoring/#258-Used_a_non-root_user_to_run…

ab3b254

…_Jupyter_in_the_Docker_Image_ai-lab

ckunki temporarily deployed to AWS_CI_TESTS February 29, 2024 12:46 — with GitHub Actions Inactive

tkilias approved these changes Feb 29, 2024

View reviewed changes

ckunki merged commit addfa42 into main Feb 29, 2024
6 checks passed

ckunki deleted the refactoring/#258-Used_a_non-root_user_to_run_Jupyter_in_the_Docker_Image_ai-lab branch February 29, 2024 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring/#258 used a non root user to run jupyter in the docker image ai lab #231

Refactoring/#258 used a non root user to run jupyter in the docker image ai lab #231

ckunki commented Feb 26, 2024 •

edited

Loading

ckunki Feb 27, 2024

Refactoring/#258 used a non root user to run jupyter in the docker image ai lab #231

Refactoring/#258 used a non root user to run jupyter in the docker image ai lab #231

Conversation

ckunki commented Feb 26, 2024 • edited Loading

ckunki Feb 27, 2024

Choose a reason for hiding this comment

ckunki commented Feb 26, 2024 •

edited

Loading