Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud storage notebook test #201

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Cloud storage notebook test #201

merged 9 commits into from
Feb 19, 2024

Conversation

Shmuma
Copy link
Contributor

@Shmuma Shmuma commented Feb 15, 2024

Closes #179

@tkilias
Copy link
Collaborator

tkilias commented Feb 19, 2024

I took a look at the failing tests. The transformer test that fails is hopefully only a flaky issue. Regarding your fixture not found problem. I recognized a general issue in the notebook tests. The pytest fixtures are not defined in the conftest.py. That means pytest doesn't find them usually. @ahsimb imported them directly that seems to work, but it is not the usual way.

@Shmuma Shmuma marked this pull request as ready for review February 19, 2024 10:10
@Shmuma Shmuma merged commit 75b3f71 into main Feb 19, 2024
6 checks passed
@Shmuma Shmuma deleted the tests/cloud_nb branch February 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckunki ckunki ckunki approved these changes

@tkilias tkilias tkilias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notebook test for Cloud Storage Extension Notebooks
3 participants
@Shmuma @tkilias @ckunki