Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed all occurrences of script-languages-developer-sandbox by data-science-sandbox #13

Merged
merged 21 commits into from
Oct 23, 2023

Conversation

ckunki
Copy link
Contributor

@ckunki ckunki commented Oct 17, 2023

Currently changed only names related to AWS resources and build artifacts.

Closes #5

Currently changed only names related to AWS resources and build artifacts.
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 17, 2023 13:16 — with GitHub Actions Inactive
from exasol_script_languages_developer_sandbox
to exasol.ds.sandbox
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 18, 2023 08:59 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 18, 2023 10:26 — with GitHub Actions Inactive
@ckunki ckunki changed the title Applied first round of renamings. Renamed all occurrences of script-languages-developer-sandbox by data-science-sandbox Oct 18, 2023
@ahsimb
Copy link
Collaborator

ahsimb commented Oct 18, 2023

Below is my search for the word "developer" in your branch. Not all findings are relevant, but I think most are.
I guess renaming in the guides can wait till we change the actual text.

Targets
Occurrences of 'developer' in Project
Found Occurrences in Project (42 usages found)
Unclassified (29 usages found)
data-science-sandbox (29 usages found)
(2 usages found)
poetry.lock (1 usage found)
1168 developer = ["mypy (>=0.982)", "pre-commit (>=2.20)"]
README.md (1 usage found)
16 * Developer Guide
aws-code-build/ci (4 usages found)
buildspec.yaml (2 usages found)
6 RUN_DEVELOPER_SANDBOX_CI_TEST: "true"
23 - echo RUN_DEVELOPER_SANDBOX_CI_TEST is "$RUN_DEVELOPER_SANDBOX_CI_TEST" #supposed to be true
buildspec_release.yaml (2 usages found)
30 - poetry run python3 -m exasol_script_languages_developer_sandbox.main create-vm --default-password "$DEFAULT_PASSWORD" --asset-id "$ASSET_ID" $MAKE_AMI_PUBLIC_OPTION
31 - poetry run python3 -m exasol_script_languages_developer_sandbox.main update-release --release-id "$RELEASE_ID" --asset-id "$ASSET_ID"
doc/changes (2 usages found)
changes_0.1.0.md (2 usages found)
1 # script-languages-developer-sandbox 0.1.0, released t.b.d.
23 - #5: Renamed all occurrences of "script language developer" by "data science"
doc/developer_guide (5 usages found)
developer_guide.md (5 usages found)
1 # Script-Languages-Developer-Sandbox Developer Guide
28 script-languages-developer-sandbox uses AWS as backend, because it provides the possibility to run the whole workflow during a ci-test.
55 ### Developer commands
122 "DEVELOPER-SANDBOX-VM-SLC-BUCKET", "DEVELOPER-SANDBOX-CI-TEST-CODEBUILD" & "DEVELOPER-SANDBOX-RELEASE-CODEBUILD
123 The EC2-stack lives only during the creation of a new developer sandbox image.
doc/user_guide (7 usages found)
user_guide.md (7 usages found)
1 # Script-Languages-Developer-Sandbox User Guide
21 The AMI id is linked in the release notes and can be used to start an EC2-instance in your AWS account.
22 Following name format is used for the AMI: "Exasol-SLC-Developer-Sandbox-version", e.g. "Exasol-SLC-Developer-Sandbox-5.0.0"
72 - At field "Application and OS Images" select the AMI id of the developer sandbox (found in the release notes)
93 1. Download the VMDK file from the release notes.
132 The images are tightly coupled to the releases of script-languages-release; for each release of the script-languages-release there will be a release of the developer sandbox.
133 the tag of the respective release, e.g. a Developer Sandbox image for release 5.0.0 will have the tag 5.0.0 checked out for script-languages-release.
exasol/ds/sandbox/templates (9 usages found)
ci_code_build.jinja.yaml (4 usages found)
69 DeveloperSandboxCICodeBuild:
72 Description: CI Build which runs CI test if script-languages-developer-sandbox
105 Value: !Ref DeveloperSandboxCICodeBuild
106 Description: Developer Sandbox CI Build project name
release_code_build.jinja.yaml (5 usages found)
73 Resource: arn:aws:s3:::{{vm_bucket}}/slc_developer_sandbox/*
75 DeveloperSandboxReleaseCodeBuild:
78 Description: Release Build which creates a new AMI and VM iso images on script-languages-developer-sandbox
101 Value: !Ref DeveloperSandboxReleaseCodeBuild
102 Description: Developer Sandbox Release Build project name
Usage in comments (5 usages found)
data-science-sandbox (5 usages found)
exasol/ds/sandbox/cli/commands (2 usages found)
start_release_build.py (1 usage found)
29 This command triggers the AWS release Codebuild to generate a new developer sandbox version.
start_test_release_build.py (1 usage found)
30 This command triggers the AWS release Codebuild to generate a new developer sandbox test version.
exasol/ds/sandbox/lib/asset_printing (3 usages found)
print_assets.py (3 usages found)
147 # For example "slc_developer_sandbox/5.0.0/export-ami-01be860e6a6a98bf8.vhd"
150 # We call list_s3_object with the standard prefix (e.g. "slc_developer_sandbox"),
155 # => Assume that a filter is given "5.0.0". Variable prefix would be "slc_developer_sandbox/5.0.0".
Usage in string constants (8 usages found)
data-science-sandbox (8 usages found)
(1 usage found)
poetry.lock (1 usage found)
376 description = "cryptography is a package which provides cryptographic recipes and primitives to Python developers."
exasol/ds/sandbox/lib/export_vm (1 usage found)
rename_s3_objects.py (1 usage found)
17 return "{bucket_prefix}exasol-data-science-developer-sandbox-{asset_id}.{img_format}".format(
exasol/ds/sandbox/templates (6 usages found)
ci_code_build.jinja.yaml (2 usages found)
92 Location: "https://github.com/exasol/script-languages-developer-sandbox"
100 LogGroupName: !Sub "/aws/codebuild/${ DeveloperSandboxCICodeBuild }"
release_code_build.jinja.yaml (2 usages found)
88 Location: "https://github.com/exasol/script-languages-developer-sandbox"
96 LogGroupName: !Sub "/aws/codebuild/${ DeveloperSandboxReleaseCodeBuild }"
vm_bucket_cloudformation.jinja.yaml (2 usages found)
7 Comment: 'Bucket to store script-language developer sandbox VM images'
60 - !Sub "arn:aws:s3:::${ VMBucket }/slc_developer_sandbox/*"

@ahsimb ahsimb closed this Oct 18, 2023
@ahsimb ahsimb reopened this Oct 18, 2023
README.md Outdated Show resolved Hide resolved
in additional files that have been overseen initially.
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 19, 2023 07:24 — with GitHub Actions Inactive
@tkilias
Copy link
Collaborator

tkilias commented Oct 19, 2023

I searched the branch with

grep -I --exclude=script-languages.ipynb --exclude-dir=ansible -R slc

the result

doc/user_guide/user_guide.md:* All necessary dependencies to execute _exaslct_ in script-languages-release (This includes a correctly configured docker runtime)
doc/user_guide/user_guide.md:- [exaslct User Guide](https://github.com/exasol/script-languages-container-tool/blob/main/doc/user_guide/user_guide.md) - Details about the build tool
doc/user_guide/user_guide.md:There is a pre-loaded tutorial notebook available which guides you through the usage of `exaslct`:  __script-languages.ipynb__.
test/ansible_conflict/slc_setup.yml:    - import_tasks: slc_setup_tasks.yml
test/cloudformation_validation.py:    out_file = tmp_path / "slc_source_credential.yaml"
test/aws_mock_data.py:TEST_BUCKET_ID = 'vm-slc-bucket-vmslcbucket-TEST'
test/aws_mock_data.py:                'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/aws_mock_data.py:        'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/aws_mock_data.py:            'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}]
test/aws_mock_data.py:            'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}]
test/aws_mock_data.py:        'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/aws_mock_data.py:        'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/aws_mock_data.py:        'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/aws_mock_data.py:        'Tags': [{'Key': 'exa_slc_id', 'Value': DEFAULT_ASSET_ID.tag_value}],
test/test_ansible.py:    expected_ansible_run_context = AnsibleRunContext(playbook="slc_setup.yml",
test/test_ansible.py:                                                     extra_vars={"slc_version": test_config.slc_version})
test/test_ansible.py:                                                     extra_vars={"slc_version": test_config.slc_version})
test/test_ansible.py:                                                     extra_vars={"slc_version": test_config.slc_version,
test/test_ansible.py:        p = pathlib.Path(work_dir) / "slc_setup.yml"
test/test_ansible.py:        p = pathlib.Path(f"{work_dir}/slc_setup.yml")
test/test_ansible.py:        p = pathlib.Path(f"{work_dir}/slc_setup_test.yml")
test/test_ci.py:def test_exaslct_with_ec2_based_on_new_ami(new_ec2_from_ami):
test/test_ci.py:    This test validates that exaslct is correctly working on the EC-2 instance, which was launched from the
test/test_ci.py:            cmd = "./exaslct build --flavor-path ./flavors/python-3.8-minimal-EXASOL-6.2.0"
test/test_deploy_vm_bucket.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import run_setup_vm_bucket, find_vm_bucket, \
test/test_deploy_vm_bucket.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import STACK_NAME as VM_STACK_NAME
test/test_deploy_vm_bucket_waf.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket_waf import run_setup_vm_bucket_waf, \
test/test_install_dependencies.py:            AnsibleRunContext(playbook="slc_setup_test.yml",
test/test_install_dependencies.py:                                          "slc_dest_folder": f"{tmp_dir}/script-languages-release"})
test/test_install_dependencies.py:    slc_command = "./exaslct build --flavor-path ./flavors/python-3.8-minimal-EXASOL-6.2.0"
test/test_install_dependencies.py:    exit_code_build, output = container.exec_run(slc_command, workdir=f"{tmp_dir}/script-languages-release")
test/test_install_dependencies.py:    slc_command = "./exaslct clean-flavor-images --flavor-path ./flavors/python-3.8-minimal-EXASOL-6.2.0"
test/test_install_dependencies.py:    exit_code_cleanup, output = container.exec_run(slc_command, workdir=f"{tmp_dir}/script-languages-release")
test/test_release_build.py:        {"name": "ASSET_ID", "value": test_config.slc_version, "type": "PLAINTEXT"},
exasol/ds/sandbox/cli/commands/setup_vm_bucket.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import run_setup_vm_bucket
exasol/ds/sandbox/cli/commands/setup_vm_bucket_waf.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket_waf import run_setup_vm_bucket_waf
exasol/ds/sandbox/lib/asset_printing/print_assets.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import find_vm_bucket, find_url_for_bucket
exasol/ds/sandbox/lib/aws_access/deployer.py:                 changeset_prefix="slc-ci-setup-deploy-"):
exasol/ds/sandbox/lib/config.py:    "slc_version": SLC_VERSION,
exasol/ds/sandbox/lib/export_vm/run_export_vm.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import find_vm_bucket, find_vm_import_role
exasol/ds/sandbox/lib/release_build/run_release_build.py:    _execute_release_build(aws_access, branch, asset_id=config.slc_version,
exasol/ds/sandbox/lib/setup_ci_codebuild/ci_codebuild.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import find_vm_bucket
exasol/ds/sandbox/lib/setup_ec2/run_install_dependencies.py:    new_extra_vars = {"slc_version": configuration.slc_version}
exasol/ds/sandbox/lib/setup_release_codebuild/release_codebuild.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket import find_vm_bucket
exasol/ds/sandbox/lib/tags.py:DEFAULT_TAG_KEY = "exa_slc_id"
exasol/ds/sandbox/lib/vm_bucket/vm_slc_bucket.py:from exasol.ds.sandbox.lib.vm_bucket.vm_slc_bucket_waf import find_acl_arn

@tkilias
Copy link
Collaborator

tkilias commented Oct 19, 2023

grep -I --exclude=script-languages.ipynb --exclude-dir=ansible --exclude=poetry.lock -R script-languages

I think, you changed this password in the CodeBuild CI

...
doc/user_guide/user_guide.md:**Password**: `script-languages`

@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 19, 2023 13:24 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 20, 2023 11:47 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 20, 2023 12:31 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 20, 2023 12:50 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 20, 2023 13:31 — with GitHub Actions Inactive
@ckunki ckunki temporarily deployed to AWS_CI_TESTS October 23, 2023 10:52 — with GitHub Actions Inactive
@ckunki ckunki merged commit 5c0b489 into main Oct 23, 2023
3 checks passed
@ckunki ckunki deleted the refactoring/#5-rename-slds-to-dss branch October 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all occurences of script-languages-developer-sandbox to data-science-sandbox
3 participants